8347841: Test fixes that use deprecated time zone IDs by naotoj · Pull Request #23166 · openjdk/jdk

naotoj · 2025-01-16T23:38:48Z

This fix is a follow on for JDK-8342550. Replaces/Removes usages of those deprecated time zone ids in tests.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8347841: Test fixes that use deprecated time zone IDs (Bug - P4)

Reviewers

Justin Lu (@justin-curtis-lu - Committer)
Joe Wang (@JoeWang-Java - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23166/head:pull/23166
$ git checkout pull/23166

Update a local copy of the PR:
$ git checkout pull/23166
$ git pull https://git.openjdk.org/jdk.git pull/23166/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23166

View PR using the GUI difftool:
$ git pr show -t 23166

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23166.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-01-16T23:39:39Z

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-01-16T23:40:05Z

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347841: Test fixes that use deprecated time zone IDs

Reviewed-by: jlu, joehw

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

baca7da: 8347733: Replace SIZE_FORMAT in runtime code
2ca1b4d: 8347840: Fix testlibrary compilation warnings
2c41f5a: 8347959: ThreadDumper leaks memory
15e06b6: 8345618: javax/swing/text/Caret/8163124/CaretFloatingPointAPITest.java leaves Caret is not complete
3ab521e: 8347924: Replace SIZE_FORMAT in memory and metaspace
8460072: 8342881: RISC-V: secondary_super_cache does not scale well: C1 and interpreter
f5573f5: 8330851: C2: More efficient TypeFunc creation
a3eef6c: 8346875: Test jdk/jdk/jfr/event/os/TestCPULoad.java fails on macOS
398a580: 8347911: Limit the length of inflated text chunks
aa21de5: 8347481: C2: Remove the control input of some nodes
... and 17 more: https://git.openjdk.org/jdk/compare/cfe70ebcb3a9fadceac5eccdc1f3353d0d74c235...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-01-16T23:40:35Z

@naotoj The following labels will be automatically applied to this pull request:

core-libs
i18n
security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-01-16T23:43:44Z

Webrevs

01: Full - Incremental (f3531f26)
00: Full (e5b58ef7)

justin-curtis-lu

Looks good.

justin-curtis-lu · 2025-01-16T23:54:04Z

test/jdk/java/util/TimeZone/TimeZoneBoundaryTest.java

-        // "EST" is disabled because its behavior depends on the mapping property. (6466476).
-        //findBoundariesStepwise(1997, ONE_DAY, TimeZone.getTimeZone("EST"), 2);
-        findBoundariesStepwise(1997, ONE_DAY, TimeZone.getTimeZone("HST"), 0);
-        findBoundariesStepwise(1997, ONE_DAY, TimeZone.getTimeZone("PST"), 2);


"PST" to "America/Los_Angeles" not needed?

It's already there at L421

Right, looks good then.

justin-curtis-lu · 2025-01-17T00:28:52Z

test/jdk/java/text/Format/DateFormat/DateFormatTest.java

        //logln(((SimpleDateFormat)fmt).toPattern());
        TimeZone save = TimeZone.getDefault();
-        TimeZone PST  = TimeZone.getTimeZone("PST");
+        TimeZone PST  = TimeZone.getTimeZone("America/Los_Angeles");


nit: extra space after "PST" here and below.

naotoj · 2025-01-21T18:29:37Z

Thanks for the reviews!
/integrate

openjdk · 2025-01-21T18:29:57Z

Going to push as commit 81912e9.
Since your change was applied there have been 58 commits pushed to the master branch:

3d4afc4: 8345079: Simplify/cleanup Exception handling in RMIConnectionImpl
a62a870: 8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java
8e8c948: 8346866: [ASAN] memoryReserver.cpp reported applying non-zero offset to non-null pointer produced null pointer
1ed396b: 8346927: serviceability/dcmd/vm/[SystemMapTest.java|SystemDumpMapTest.java] fail at jmx
5c4a387: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
48c7597: 8348029: Make gtest death tests work with real crash signals
4a9fba6: 8347990: Remove SIZE_FORMAT macros and replace remaining uses
c33c1cf: 8347909: Automatic precompiled.hpp inclusion
f54e0bf: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing
0f426e4: 8343685: C2 SuperWord: refactor VPointer with MemPointer
... and 48 more: https://git.openjdk.org/jdk/compare/cfe70ebcb3a9fadceac5eccdc1f3353d0d74c235...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-01-21T18:30:03Z

@naotoj Pushed as commit 81912e9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

initial commit

e5b58ef

openjdk bot added the rfr Pull request is ready for review label Jan 16, 2025

openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 16, 2025

justin-curtis-lu approved these changes Jan 17, 2025

View reviewed changes

Removed extra spaces

f3531f2

justin-curtis-lu approved these changes Jan 17, 2025

View reviewed changes

JoeWang-Java approved these changes Jan 17, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jan 17, 2025

openjdk bot added the integrated Pull request has been integrated label Jan 21, 2025

openjdk bot closed this Jan 21, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 21, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8347841: Test fixes that use deprecated time zone IDs#23166

8347841: Test fixes that use deprecated time zone IDs#23166
naotoj wants to merge 2 commits intoopenjdk:masterfrom
naotoj:JDK-8347841-Test-deprecated-IDs

naotoj commented Jan 16, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jan 16, 2025

Uh oh!

openjdk bot commented Jan 16, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Jan 16, 2025

Uh oh!

mlbridge bot commented Jan 16, 2025 •

edited

Loading

Uh oh!

justin-curtis-lu left a comment

Uh oh!

justin-curtis-lu Jan 16, 2025

Uh oh!

naotoj Jan 17, 2025

Uh oh!

justin-curtis-lu Jan 17, 2025

Uh oh!

justin-curtis-lu Jan 17, 2025

Uh oh!

naotoj commented Jan 21, 2025

Uh oh!

openjdk bot commented Jan 21, 2025

Uh oh!

openjdk bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

naotoj commented Jan 16, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jan 16, 2025

Uh oh!

openjdk bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jan 16, 2025

Uh oh!

mlbridge bot commented Jan 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

justin-curtis-lu left a comment

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu Jan 16, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu Jan 17, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj commented Jan 21, 2025

Uh oh!

openjdk bot commented Jan 21, 2025

Uh oh!

openjdk bot commented Jan 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

naotoj commented Jan 16, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jan 16, 2025 •

edited

Loading

mlbridge bot commented Jan 16, 2025 •

edited

Loading