8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java

[dfuch]

The jdk/java/net/httpclient/offline/FixedResponseHttpClient.java test class makes unreasonable assumptions on BodyPublisher implementation. There's no guarantee that all buffers will be available until the subscriber is completed.
The fix is to wait for completion before getting the consumed buffers.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewers without OpenJDK IDs

• @vy (no known openjdk.org user name / role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23176/head:pull/23176
$ git checkout pull/23176

Update a local copy of the PR:
$ git checkout pull/23176
$ git pull https://git.openjdk.org/jdk.git pull/23176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23176

View PR using the GUI difftool:
$ git pr show -t 23176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23176.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347995: Race condition in jdk/java/net/httpclient/offline/FixedResponseHttpClient.java

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 31 new commits pushed to the master branch:

• 8e8c948: 8346866: [ASAN] memoryReserver.cpp reported applying non-zero offset to non-null pointer produced null pointer
• 1ed396b: 8346927: serviceability/dcmd/vm/[SystemMapTest.java|SystemDumpMapTest.java] fail at jmx
• 5c4a387: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
• 48c7597: 8348029: Make gtest death tests work with real crash signals
• 4a9fba6: 8347990: Remove SIZE_FORMAT macros and replace remaining uses
• c33c1cf: 8347909: Automatic precompiled.hpp inclusion
• f54e0bf: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing
• 0f426e4: 8343685: C2 SuperWord: refactor VPointer with MemPointer
• 6b91985: 8346157: [Ubsan]: runtime error: pointer index expression with base 0x000000001000 overflowed to 0xfffffffffffffff0
• 955bf18: 8348040: Bad use of ifdef with INCLUDE_xxx GC macros
• ... and 21 more: https://git.openjdk.org/jdk/compare/2c41f5adbfcebb057c2ffc8396729bdd1c100079...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (482db137)

[vy]

Is this method really needed? Above you can replace subscriber.getBuffers().join() with subscriber.consumed.join() too.

[dfuch]

I could have. I preferred calling a method though.

[jaikiran]

This looks good to me.

[dfuch]

/integrate

[openjdk]

Going to push as commit a62a870.
Since your change was applied there have been 31 commits pushed to the master branch:

• 8e8c948: 8346866: [ASAN] memoryReserver.cpp reported applying non-zero offset to non-null pointer produced null pointer
• 1ed396b: 8346927: serviceability/dcmd/vm/[SystemMapTest.java|SystemDumpMapTest.java] fail at jmx
• 5c4a387: 8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently
• 48c7597: 8348029: Make gtest death tests work with real crash signals
• 4a9fba6: 8347990: Remove SIZE_FORMAT macros and replace remaining uses
• c33c1cf: 8347909: Automatic precompiled.hpp inclusion
• f54e0bf: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing
• 0f426e4: 8343685: C2 SuperWord: refactor VPointer with MemPointer
• 6b91985: 8346157: [Ubsan]: runtime error: pointer index expression with base 0x000000001000 overflowed to 0xfffffffffffffff0
• 955bf18: 8348040: Bad use of ifdef with INCLUDE_xxx GC macros
• ... and 21 more: https://git.openjdk.org/jdk/compare/2c41f5adbfcebb057c2ffc8396729bdd1c100079...master

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit a62a870.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.