8344361: Restore null return for invalid services from legacy providers

[coffeys]

Correct a corner case where null should be returned if a service from the legacyMap is marked invalid.

New test case added.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8344361: Restore null return for invalid services from legacy providers (Bug - P3)

Reviewers

• Valerie Peng (@valeriepeng - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23201/head:pull/23201
$ git checkout pull/23201

Update a local copy of the PR:
$ git checkout pull/23201
$ git pull https://git.openjdk.org/jdk.git pull/23201/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23201

View PR using the GUI difftool:
$ git pr show -t 23201

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23201.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coffeys! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coffeys This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8344361: Restore null return for invalid services from legacy providers

Reviewed-by: valeriep

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 64 new commits pushed to the master branch:

• 48ece07: 8282862: AwtWindow::SetIconData leaks old icon handles if an exception is detected
• 356e2a8: 8348406: Remove tests GrantAllPermToExtWhenNoPolicy and PrincipalExpansionError from problem list
• 3ebf889: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c
• d9d2e19: 8348365: Bad format string in CLDRDisplayNamesTest
• 59e7509: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests
• 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
• cba0f78: 8348387: Add fixpath if needed for user-supplied tools
• 44e5cca: 8348391: Keep case if possible for TOPDIR
• 7460a0a: 8348392: Make claims "other matches are possible" even when that is not true
• 5cc690d: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures
• ... and 54 more: https://git.openjdk.org/jdk/compare/0fbf10a9cf51d01d82cd43cf0edfaeee83313a9c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coffeys The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3dab0d77)

[valeriepeng]

Looks good to me. Thanks~

[coffeys]

Thanks for the review Valerie

/integrate

[openjdk]

Going to push as commit e20bd01.
Since your change was applied there have been 74 commits pushed to the master branch:

• 5a0bdd0: 8346890: AArch64: Type profile counters generate suboptimal code
• 4a375e5: 8344232: [PPC64] secondary_super_cache does not scale well: C1 and interpreter
• 0df9dcb: 8346572: Check is_reserved() before using ReservedSpace instances
• a09f06d: 8348265: RMIConnectionImpl: Remove Subject.callAs on MarshalledObject
• 0395593: 8346751: Internal java compiler error with type annotations in constants expression in constant fields
• 2daafe4: 8348283: java.lang.classfile.components.snippets.PackageSnippets shipped in java.base.jmod
• 50ca450: 8340784: Remove PassFailJFrame constructor with screenshots
• 416d469: 8347008: beancontext package spec does not clearly explain why the API is deprecated
• 471d63c: 8343609: Broken links in java.xml
• 7f16a08: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class()
• ... and 64 more: https://git.openjdk.org/jdk/compare/0fbf10a9cf51d01d82cd43cf0edfaeee83313a9c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coffeys Pushed as commit e20bd01.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.