8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

[fguallini]

The test javax/crypto/CryptoPermissions/InconsistentEntries.java should not modify the JDK home directory under test as that could impact the results of other tests, or it could fail if the JDK home dir is read-only.

This PR updates the test to

• clone the tested JDK into the scratch directory.
• create the required directory and file in the cloned JDK directory.
• run a subprocess using the temporal JDK to test the scenario.

There is no need to explicitly remove the tests files with an 'after' step, as JTreg will handle cleaning the scratch directory

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir (Bug - P3)

Reviewers

• Jamil Nimeh (@jnimeh - Reviewer)
• Rajan Halade (@rhalade - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23202/head:pull/23202
$ git checkout pull/23202

Update a local copy of the PR:
$ git checkout pull/23202
$ git pull https://git.openjdk.org/jdk.git pull/23202/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23202

View PR using the GUI difftool:
$ git pr show -t 23202

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23202.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8342238: Test javax/crypto/CryptoPermissions/InconsistentEntries.java writes files in tested JDK dir

Reviewed-by: jnimeh, rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 449 new commits pushed to the master branch:

• 1eb0db3: 8350151: Support requires property to filter tests incompatible with --enable-preview
• 1687373: 8349933: Mixing of includes and snippets stack causes the wrong -post snippet to be included
• 53db576: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools
• 10bf48a: 8350214: Test gtest/AsyncLogGtest.java fails after JDK-8349755
• 960ad21: 8349620: Add VMProps for static JDK
• 735805d: 8349727: [PPC] C1: Improve Class.isInstance intrinsic
• 1e87ff0: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS
• 86d0616: 8350303: ARM32: StubCodeGenerator::verify_stub(StubGenStubId) failed after JDK-8343767
• 0662e39: 8350267: Set mtune and mcpu settings in JDK native lib compilation on Linux ppc64(le)
• c5c91a8: 8345285: [s390x] test failures: foreign/normalize/TestNormalize.java with C2
• ... and 439 more: https://git.openjdk.org/jdk/compare/af3f5d852e5dd0191548bdc477546b5b343d1276...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jnimeh, @rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fguallini The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (f1c8db61)

[bridgekeeper]

@fguallini This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[fguallini]

Hi, please a review is needed.

[jnimeh]

@fguallini I'm looking it over now.

[fguallini]

/integrate

[openjdk]

@fguallini
Your change (at version f1c8db6) is now ready to be sponsored by a Committer.

[rhalade]

/sponsor

[openjdk]

Going to push as commit 16033ea.
Since your change was applied there have been 450 commits pushed to the master branch:

• f979f72: 8337723: Remove redundant tests from com/sun/security/sasl/gsskerb
• 1eb0db3: 8350151: Support requires property to filter tests incompatible with --enable-preview
• 1687373: 8349933: Mixing of includes and snippets stack causes the wrong -post snippet to be included
• 53db576: 8350137: After JDK-8348975, Linux builds contain man pages for windows only tools
• 10bf48a: 8350214: Test gtest/AsyncLogGtest.java fails after JDK-8349755
• 960ad21: 8349620: Add VMProps for static JDK
• 735805d: 8349727: [PPC] C1: Improve Class.isInstance intrinsic
• 1e87ff0: 8348936: [Accessibility,macOS,VoiceOver] VoiceOver doesn't announce untick on toggling the checkbox with "space" key on macOS
• 86d0616: 8350303: ARM32: StubCodeGenerator::verify_stub(StubGenStubId) failed after JDK-8343767
• 0662e39: 8350267: Set mtune and mcpu settings in JDK native lib compilation on Linux ppc64(le)
• ... and 440 more: https://git.openjdk.org/jdk/compare/af3f5d852e5dd0191548bdc477546b5b343d1276...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rhalade @fguallini Pushed as commit 16033ea.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.