8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently

[dfuch]

The test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java has been observed failing at least once. The suspicion is that it may be due to the client URI using "localhost" instead of a literal IP.

The test has also been slightly refactored to close the created HttpClient instances after use.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently (Bug - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23203/head:pull/23203
$ git checkout pull/23203

Update a local copy of the PR:
$ git checkout pull/23203
$ git pull https://git.openjdk.org/jdk.git pull/23203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23203

View PR using the GUI difftool:
$ git pr show -t 23203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23203.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348107: test/jdk/java/net/httpclient/HttpsTunnelAuthTest.java fails intermittently

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

• c33c1cf: 8347909: Automatic precompiled.hpp inclusion
• f54e0bf: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing
• 0f426e4: 8343685: C2 SuperWord: refactor VPointer with MemPointer
• 6b91985: 8346157: [Ubsan]: runtime error: pointer index expression with base 0x000000001000 overflowed to 0xfffffffffffffff0
• 955bf18: 8348040: Bad use of ifdef with INCLUDE_xxx GC macros
• ca863fd: 8347758: modules.cpp leaks string returned from get_numbered_property_as_sorted_string()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dfuch The following label will be automatically applied to this pull request:

• net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fad6b4fc)

[jaikiran]

The servers that are created in these tests (through the DigestEchoServer) go through various layers during creation but they do indeed use loopback address for binding. So this change to use loopback address for the client request URI looks fine to me.

[dfuch]

/integrate

[openjdk]

Going to push as commit 5c4a387.
Since your change was applied there have been 8 commits pushed to the master branch:

• 48c7597: 8348029: Make gtest death tests work with real crash signals
• 4a9fba6: 8347990: Remove SIZE_FORMAT macros and replace remaining uses
• c33c1cf: 8347909: Automatic precompiled.hpp inclusion
• f54e0bf: 8345766: C2 should emit macro nodes for ModF/ModD instead of calls during parsing
• 0f426e4: 8343685: C2 SuperWord: refactor VPointer with MemPointer
• 6b91985: 8346157: [Ubsan]: runtime error: pointer index expression with base 0x000000001000 overflowed to 0xfffffffffffffff0
• 955bf18: 8348040: Bad use of ifdef with INCLUDE_xxx GC macros
• ca863fd: 8347758: modules.cpp leaks string returned from get_numbered_property_as_sorted_string()

Your commit was automatically rebased without conflicts.

[openjdk]

@dfuch Pushed as commit 5c4a387.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.