8337458: Remove debugging code print_cpool_bytes

[coleenp]

Please review this change to remove debug printing code that was added temporarily for the ClassFileReconstituter to debug constant pool copying a long time ago, that is now unused.
Tested with tier1 locally.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8337458: Remove debugging code print_cpool_bytes (Bug - P4)

Reviewers

• David Holmes (@dholmes-ora - Reviewer)
• Aleksey Shipilev (@shipilev - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23222/head:pull/23222
$ git checkout pull/23222

Update a local copy of the PR:
$ git checkout pull/23222
$ git pull https://git.openjdk.org/jdk.git pull/23222/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23222

View PR using the GUI difftool:
$ git pr show -t 23222

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23222.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back coleenp! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@coleenp This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337458: Remove debugging code print_cpool_bytes

Reviewed-by: dholmes, shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 9b98cc0: 8348182: Remove DONT_USE_PRECOMPILED_HEADER
• d777218: 8346830: Simplify adlc build config for aix
• 15d6469: 8347817: Timeouts running test/jdk/java/lang/String/concat/HiddenClassUnloading.java with fastdebug builds
• 3c2a1d8: 8348117: The two-argument overload of SignatureHandlerLibrary::add is not used
• 8458f88: 8347475: GTK: javax/swing/JColorChooser/Test8152419.java there are no swatches or RGB tab in JColorChooser
• 7a6ff92: 8345543: Test serviceability/jvmti/vthread/StopThreadTest/StopThreadTest.java failed: expected JVMTI_ERROR_OPAQUE_FRAME instead of: 0
• bbd8807: 8338428: Add logging of final VM flags while setting properties

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@coleenp The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (9ad94ff6)

[coleenp]

/label add serviceability

[openjdk]

@coleenp
The serviceability label was successfully added.

[dholmes-ora]

Looks fine. Thanks for cleaning it up.

[coleenp]

Thanks for reviewing David and Aleksey.
/integrate

[openjdk]

Going to push as commit 86a8b48.
Since your change was applied there have been 15 commits pushed to the master branch:

• 16a1d0a: 8348135: Fix couple of problem listing entries in test/hotspot/jtreg/ProblemList-Virtual.txt
• 16dcf15: 8348263: C2 SuperWord: TestMemorySegment.java has failing IR rules with AlignVector after JDK-8343685
• 6187356: Merge
• 5f6c854: 8330045: Enhance array handling
• fa83309: 8339180: Enhanced Building of Processes: Follow-on Issue
• 496d06f: 8336564: Enhance mask blit functionality redux
• 46b2481: 8335428: Enhanced Building of Processes
• fb43849: 8347794: RISC-V: Add Zfhmin - Float cleanup
• 9b98cc0: 8348182: Remove DONT_USE_PRECOMPILED_HEADER
• d777218: 8346830: Simplify adlc build config for aix
• ... and 5 more: https://git.openjdk.org/jdk/compare/c38417a86e27f047715cfd9a98770387d994a512...master

Your commit was automatically rebased without conflicts.

[openjdk]

@coleenp Pushed as commit 86a8b48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.