8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

[shipilev]

Reference.waitForReferenceProcessing is in internal API, which should go away with JDK-8344332. There is single use of that internal API in the tests, the last use of which was removed by JDK-8080225. We can remove the Reference.waitForReferenceProcessing break-ins in the tests now.

Additional testing:

• Affected test still passes

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests (Enhancement - P4)

Reviewers

• Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23239/head:pull/23239
$ git checkout pull/23239

Update a local copy of the PR:
$ git checkout pull/23239
$ git pull https://git.openjdk.org/jdk.git pull/23239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23239

View PR using the GUI difftool:
$ git pr show -t 23239

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23239.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 57 new commits pushed to the master branch:

• 89bfcb8: 8348308: Make fields of ListSelectionEvent final
• 17df515: 8348303: Remove repeated 'a' from ListSelectionEvent
• 337118d: 8348388: Incorrect copyright header in TestFluidAndNonFluid.java
• 3069e91: 8344969: Remove the jmx.mxbean.multiname compatibility property
• c882160: 8344966: Remove the allowNonPublic MBean compatibility property
• 6032f6e: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat
• caa3c78: 8347965: (tz) Update Timezone Data to 2025a
• e69e5b7: 8348324: The failure handler cannot be build by JDK 24 due to restricted warning
• 66513dd: 8337997: MallocHeader description refers to non-existent NMT state "minimal"
• 8cf0735: 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently
• ... and 47 more: https://git.openjdk.org/jdk/compare/4b4b1e912a3193cc95c956acc770015f707449b1...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4abe812e)

[shipilev]

/label add core-libs

[openjdk]

@shipilev
The core-libs label was successfully added.

[AlanBateman]

So the test wasn't actually calling Reference::waitForReferenceProcessing, do I have this right? In that case, this PR looks fine.

[shipilev]

So the test wasn't actually calling Reference::waitForReferenceProcessing, do I have this right? In that case, this PR looks fine.

Yup. The last use of Reference::waitForReferenceProcessing was removed by JDK-8080225

[shipilev]

I think I need another review for integration?

[seanjmullan]

I think I need another review for integration?

Alan's review should be sufficient I think. The bug should have a noreg-self label.

[shipilev]

All right, thanks. Added noreg-self to the bug.

/integrate

[openjdk]

Going to push as commit 59e7509.
Since your change was applied there have been 65 commits pushed to the master branch:

• 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
• cba0f78: 8348387: Add fixpath if needed for user-supplied tools
• 44e5cca: 8348391: Keep case if possible for TOPDIR
• 7460a0a: 8348392: Make claims "other matches are possible" even when that is not true
• 5cc690d: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures
• c00557f: 8345049: Remove the jmx.tabular.data.hash.map compatibility property
• 8b46db0: 8345045: Remove the jmx.remote.x.buffer.size JMX notification property
• 119899b: 8345048: Remove the jmx.extend.open.types compatibility property
• 89bfcb8: 8348308: Make fields of ListSelectionEvent final
• 17df515: 8348303: Remove repeated 'a' from ListSelectionEvent
• ... and 55 more: https://git.openjdk.org/jdk/compare/4b4b1e912a3193cc95c956acc770015f707449b1...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 59e7509.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.