8348308: Make fields of ListSelectionEvent final

[aivanov-jdk]

The fields of ListSelectionEvent are set in the constructor and are never modified, mark the fields — firstIndex, lastIndex, isAdjusting — with the final modifier.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348308: Make fields of ListSelectionEvent final (Bug - P5)

Reviewers

• Harshitha Onkar (@honkar-jdk - Reviewer)
• Alexander Zvegintsev (@azvegint - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23243/head:pull/23243
$ git checkout pull/23243

Update a local copy of the PR:
$ git checkout pull/23243
$ git pull https://git.openjdk.org/jdk.git pull/23243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23243

View PR using the GUI difftool:
$ git pr show -t 23243

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23243.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348308: Make fields of ListSelectionEvent final

Reviewed-by: honkar, azvegint

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 66513dd: 8337997: MallocHeader description refers to non-existent NMT state "minimal"
• 8cf0735: 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently
• a36e166: 8348241: ZGC: Unnecessarily reinitialize ZFragmentationLimit's default value
• b720517: 8348108: Race condition in AggregatePublisher.AggregateSubscription
• 17a408c: 8348169: Destruct values on free in Treap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@aivanov-jdk The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (bfbd882f)

[abdelhak-zaaim]

Thank you for making the fields final, improving immutability and thread-safety. However, the file header still references the copyright year as 2014. Please update it to 2025 to reflect the changes.

[aivanov-jdk]

Please update it to 2025 to reflect the changes.

File header will be updated by #23240.

[aivanov-jdk]

/integrate

[openjdk]

Going to push as commit 89bfcb8.
Since your change was applied there have been 12 commits pushed to the master branch:

• 17df515: 8348303: Remove repeated 'a' from ListSelectionEvent
• 337118d: 8348388: Incorrect copyright header in TestFluidAndNonFluid.java
• 3069e91: 8344969: Remove the jmx.mxbean.multiname compatibility property
• c882160: 8344966: Remove the allowNonPublic MBean compatibility property
• 6032f6e: 8341696: C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat
• caa3c78: 8347965: (tz) Update Timezone Data to 2025a
• e69e5b7: 8348324: The failure handler cannot be build by JDK 24 due to restricted warning
• 66513dd: 8337997: MallocHeader description refers to non-existent NMT state "minimal"
• 8cf0735: 8348102: java/net/httpclient/HttpClientSNITest.java fails intermittently
• a36e166: 8348241: ZGC: Unnecessarily reinitialize ZFragmentationLimit's default value
• ... and 2 more: https://git.openjdk.org/jdk/compare/25bb698eff9f5aadb54dd37a442e2e1bc555353a...master

Your commit was automatically rebased without conflicts.

[openjdk]

@aivanov-jdk Pushed as commit 89bfcb8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.