Skip to content

Conversation

@cushon
Copy link
Contributor

@cushon cushon commented Jan 23, 2025

This change fixes an incorrect call to printf for a failure message in CLDRDisplayNamesTest.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348365: Bad format string in CLDRDisplayNamesTest (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23252/head:pull/23252
$ git checkout pull/23252

Update a local copy of the PR:
$ git checkout pull/23252
$ git pull https://git.openjdk.org/jdk.git pull/23252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23252

View PR using the GUI difftool:
$ git pr show -t 23252

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23252.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2025

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348365: Bad format string in CLDRDisplayNamesTest

Reviewed-by: shade, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

  • 59e7509: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests
  • 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
  • cba0f78: 8348387: Add fixpath if needed for user-supplied tools
  • 44e5cca: 8348391: Keep case if possible for TOPDIR
  • 7460a0a: 8348392: Make claims "other matches are possible" even when that is not true
  • 5cc690d: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures
  • c00557f: 8345049: Remove the jmx.tabular.data.hash.map compatibility property
  • 8b46db0: 8345045: Remove the jmx.remote.x.buffer.size JMX notification property
  • 119899b: 8345048: Remove the jmx.extend.open.types compatibility property
  • 89bfcb8: 8348308: Make fields of ListSelectionEvent final
  • ... and 8 more: https://git.openjdk.org/jdk/compare/8cf0735839727300e446828f4f4a8ef6354a8c7a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@cushon The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Jan 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 23, 2025
@cushon
Copy link
Contributor Author

cushon commented Jan 23, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

Going to push as commit d9d2e19.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 59e7509: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests
  • 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
  • cba0f78: 8348387: Add fixpath if needed for user-supplied tools
  • 44e5cca: 8348391: Keep case if possible for TOPDIR
  • 7460a0a: 8348392: Make claims "other matches are possible" even when that is not true
  • 5cc690d: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures
  • c00557f: 8345049: Remove the jmx.tabular.data.hash.map compatibility property
  • 8b46db0: 8345045: Remove the jmx.remote.x.buffer.size JMX notification property
  • 119899b: 8345048: Remove the jmx.extend.open.types compatibility property
  • 89bfcb8: 8348308: Make fields of ListSelectionEvent final
  • ... and 8 more: https://git.openjdk.org/jdk/compare/8cf0735839727300e446828f4f4a8ef6354a8c7a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2025
@openjdk openjdk bot closed this Jan 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@cushon Pushed as commit d9d2e19.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants