8348283: java.lang.classfile.components.snippets.PackageSnippets shipped in java.base.jmod

[asotona]

JDK-8345486 moved java.lang.classfile.components.snippet-files.PackageSnippets to jdk.internal.classfile.components.snippet-files folder. However change of the package name declared in the snippet file was omitted.

Please review.

Thank you,
Adam

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8348283: java.lang.classfile.components.snippets.PackageSnippets shipped in java.base.jmod (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23254/head:pull/23254
$ git checkout pull/23254

Update a local copy of the PR:
$ git checkout pull/23254
$ git pull https://git.openjdk.org/jdk.git pull/23254/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23254

View PR using the GUI difftool:
$ git pr show -t 23254

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23254.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back asotona! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@asotona This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348283: java.lang.classfile.components.snippets.PackageSnippets shipped in java.base.jmod

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

• 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
• cba0f78: 8348387: Add fixpath if needed for user-supplied tools
• 44e5cca: 8348391: Keep case if possible for TOPDIR
• 7460a0a: 8348392: Make claims "other matches are possible" even when that is not true
• 5cc690d: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures
• c00557f: 8345049: Remove the jmx.tabular.data.hash.map compatibility property
• 8b46db0: 8345045: Remove the jmx.remote.x.buffer.size JMX notification property
• 119899b: 8345048: Remove the jmx.extend.open.types compatibility property
• 89bfcb8: 8348308: Make fields of ListSelectionEvent final
• 17df515: 8348303: Remove repeated 'a' from ListSelectionEvent
• ... and 6 more: https://git.openjdk.org/jdk/compare/66513ddbe97b56e3633abdd0922dd54ab42d5b28...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@asotona The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (daa120ae)

[liach]

Thanks for this fix. It's weird that we ship snippet files by its package declaration...

[asotona]

Thanks for the review.

/integrate

[openjdk]

Going to push as commit 2daafe4.
Since your change was applied there have been 25 commits pushed to the master branch:

• 50ca450: 8340784: Remove PassFailJFrame constructor with screenshots
• 416d469: 8347008: beancontext package spec does not clearly explain why the API is deprecated
• 471d63c: 8343609: Broken links in java.xml
• 7f16a08: 8348240: Remove SystemDictionaryShared::lookup_super_for_unregistered_class()
• 48ece07: 8282862: AwtWindow::SetIconData leaks old icon handles if an exception is detected
• 356e2a8: 8348406: Remove tests GrantAllPermToExtWhenNoPolicy and PrincipalExpansionError from problem list
• 3ebf889: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c
• d9d2e19: 8348365: Bad format string in CLDRDisplayNamesTest
• 59e7509: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests
• 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
• ... and 15 more: https://git.openjdk.org/jdk/compare/66513ddbe97b56e3633abdd0922dd54ab42d5b28...master

Your commit was automatically rebased without conflicts.

[openjdk]

@asotona Pushed as commit 2daafe4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.