Skip to content

Conversation

@robehn
Copy link
Contributor

@robehn robehn commented Jan 23, 2025

Hi please consider!

Linux kernels pre-6.9 can copy a dirty v-state during signal return path:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/riscv/kernel/signal.c?h=v6.13-rc1&id=c27fa53b858b4ee6552a719aa599c250cf98a586

We should not auto-enable vector with such kernel, as we must be able to receive signals during the execution of vector code.

Manual tested pre and post 6.9 as expected.

Thanks, Robbin


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348384: RISC-V: Disable auto-enable Vector on buggy kernels (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23256/head:pull/23256
$ git checkout pull/23256

Update a local copy of the PR:
$ git checkout pull/23256
$ git pull https://git.openjdk.org/jdk.git pull/23256/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23256

View PR using the GUI difftool:
$ git pr show -t 23256

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23256.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2025

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348384: RISC-V: Disable auto-enable Vector on buggy kernels

Reviewed-by: fyang, mli, luhenry

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 70eec90: 8338303: Linux ppc64le with toolchain clang - detection failure in early JVM startup

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@robehn The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2025

Webrevs

Copy link

@Hamlin-Li Hamlin-Li left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
Just a minor comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 23, 2025
@robehn
Copy link
Contributor Author

robehn commented Jan 23, 2025

Looks good. Just a minor comment.

Thank you!

@robehn
Copy link
Contributor Author

robehn commented Jan 23, 2025

Thanks @luhenry !

@robehn
Copy link
Contributor Author

robehn commented Jan 24, 2025

I'll merge with #23291 and check for 6.8.5.

@robehn
Copy link
Contributor Author

robehn commented Jan 27, 2025

Merged and updated, using kernel_compare and 6.8.5.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 27, 2025
Copy link
Member

@RealFYang RealFYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 27, 2025
@robehn
Copy link
Contributor Author

robehn commented Jan 28, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Jan 28, 2025

Going to push as commit 2537a05.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 46f48e4: 8348515: Add docs for -XX:AOT* options in java man pages
  • 1916a77: 8346923: MetaspaceShared base calculation may cause overflow in align_up
  • 21feef3: 8348239: SA does not know about DeoptimizeObjectsALotThread
  • 8cc1304: 8287788: Implement a better allocator for downcalls
  • 039e73f: 8346736: Java Security Standard Algorithm Names spec should include key algorithm names
  • aba60a9: 8189441: Define algorithm names for keys derived from KeyAgreement
  • 03106eb: 8344119: CUPSPrinter does not respect PostScript printer definition specification in case of reading ImageableArea values from PPD files
  • ad01dfb: 8346920: Serial: Support allocation in old generation when heap is almost full
  • 1d8ccb8: 8342465: Improve API documentation for java.lang.classfile
  • 7d6055a: 8348429: Update cross-compilation devkits to Fedora 41/gcc 13.2
  • ... and 6 more: https://git.openjdk.org/jdk/compare/a1fd5f4e88f52125eef4feea91a60641981177c1...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 28, 2025
@openjdk openjdk bot closed this Jan 28, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Jan 28, 2025
@openjdk openjdk bot removed the rfr Pull request is ready for review label Jan 28, 2025
@openjdk
Copy link

openjdk bot commented Jan 28, 2025

@robehn Pushed as commit 2537a05.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@robehn robehn deleted the no_V_69 branch January 28, 2025 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants