-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8348384: RISC-V: Disable auto-enable Vector on buggy kernels #23256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back rehn! A progress list of the required criteria for merging this PR into |
|
@robehn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 1 new commit pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Hamlin-Li
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
Just a minor comment.
Thank you! |
|
Thanks @luhenry ! |
|
I'll merge with #23291 and check for 6.8.5. |
|
Merged and updated, using kernel_compare and 6.8.5. |
RealFYang
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the update.
|
/integrate |
|
Going to push as commit 2537a05.
Your commit was automatically rebased without conflicts. |
Hi please consider!
Linux kernels pre-6.9 can copy a dirty v-state during signal return path:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/arch/riscv/kernel/signal.c?h=v6.13-rc1&id=c27fa53b858b4ee6552a719aa599c250cf98a586
We should not auto-enable vector with such kernel, as we must be able to receive signals during the execution of vector code.
Manual tested pre and post 6.9 as expected.
Thanks, Robbin
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23256/head:pull/23256$ git checkout pull/23256Update a local copy of the PR:
$ git checkout pull/23256$ git pull https://git.openjdk.org/jdk.git pull/23256/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23256View PR using the GUI difftool:
$ git pr show -t 23256Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23256.diff
Using Webrev
Link to Webrev Comment