Skip to content

Conversation

@theoweidmannoracle
Copy link
Contributor

@theoweidmannoracle theoweidmannoracle commented Jan 23, 2025

Fixes a missing comma in the copyright header.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348388: Incorrect copyright header in TestFluidAndNonFluid.java (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23258/head:pull/23258
$ git checkout pull/23258

Update a local copy of the PR:
$ git checkout pull/23258
$ git pull https://git.openjdk.org/jdk.git pull/23258/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23258

View PR using the GUI difftool:
$ git pr show -t 23258

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23258.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2025

👋 Welcome back tweidmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Copy link
Member

@chhagedorn chhagedorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial.

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@theoweidmannoracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348388: Incorrect copyright header in TestFluidAndNonFluid.java

Reviewed-by: epeter, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@eme64, @chhagedorn) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 23, 2025
@theoweidmannoracle
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@theoweidmannoracle The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added hotspot-compiler hotspot-compiler-dev@openjdk.org sponsor Pull request is ready to be sponsored labels Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@theoweidmannoracle
Your change (at version 2554409) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented Jan 23, 2025

Webrevs

@chhagedorn
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

Going to push as commit 337118d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2025
@openjdk openjdk bot closed this Jan 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@chhagedorn @theoweidmannoracle Pushed as commit 337118d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants