8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp

[lahodaj]

The FailOverDirectExecutionControlTest test looks-up/creates a Logger, configures it, but it is not holding it while the test is running. As a consequence, the Logger may be GCed, loosing the configuration, and consequently failing the test.

The proposal in this PR is to hold the configured Logger instance for the duration of the test.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp (Bug - P4)

Reviewers

• Chen Liang (@liach - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23265/head:pull/23265
$ git checkout pull/23265

Update a local copy of the PR:
$ git checkout pull/23265
$ git pull https://git.openjdk.org/jdk.git pull/23265/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23265

View PR using the GUI difftool:
$ git pr show -t 23265

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23265.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8347629: Test FailOverDirectExecutionControlTest.java fails with -Xcomp

Reviewed-by: liach

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 148 new commits pushed to the master branch:

• beb43e2: 8349343: Add missing copyright messages in FFM benchmarks
• e91a6ec: 8347489: RISC-V: Misaligned memory access with COH
• d699aba: 8349135: Add tests for HttpRequest.Builder.copy()
• 81126c2: 8349238: Some more FFM benchmarks are broken
• beae884: 8349150: Support precompiled headers on AIX
• c545a3e: 8346774: Use Predicate classes instead of Node classes
• 7ea176d: 8349193: compiler/intrinsics/TestContinuationPinningAndEA.java missing @requires vm.continuations
• 9b49597: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary
• 43979fb: 8347428: Avoid using secret-key in specifications
• 618c5eb: 8349183: [BACKOUT] Optimization for StringBuilder append boolean & null
• ... and 138 more: https://git.openjdk.org/jdk/compare/119899bc69a5936d2e38065d8a05705c6d37e66f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@lahodaj The following label will be automatically applied to this pull request:

• kulla

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4aabff01)

[liach]

Makes sense. LogManager keeps weak references to loggers, which is definitely not suitable for this test. We need our own explicit reference instead.

[lahodaj]

/integrate

[openjdk]

Going to push as commit 0926949.
Since your change was applied there have been 155 commits pushed to the master branch:

• a51e669: 8349200: [JMH] time.format.ZonedDateTimeFormatterBenchmark fails
• 9d23de5: 8184352: Remove Sun provider information from KeyPairGenerator javadoc
• d222c18: 8349107: Remove RMI finalizers
• bad39b6: 8348610: GenShen: TestShenandoahEvacuationInformationEvent failed with setRegions >= regionsFreed: expected 1 >= 57
• 250ff86: 8349000: Performance improvement for Currency.isPastCutoverDate(String)
• ee4caa4: 8349106: Change ChaCha20 intrinsic to use quarter-round parallel implementation on aarch64
• b985347: 8348349: Refactor CDSConfig::is_dumping_heap()
• beb43e2: 8349343: Add missing copyright messages in FFM benchmarks
• e91a6ec: 8347489: RISC-V: Misaligned memory access with COH
• d699aba: 8349135: Add tests for HttpRequest.Builder.copy()
• ... and 145 more: https://git.openjdk.org/jdk/compare/119899bc69a5936d2e38065d8a05705c6d37e66f...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit 0926949.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.