Skip to content

8348406: Remove tests GrantAllPermToExtWhenNoPolicy and PrincipalExpansionError from problem list #23275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

myankelev
Copy link
Member

@myankelev myankelev commented Jan 23, 2025

The following test files were deleted and has been removed from the problem list:

  • sun/security/provider/PolicyFile/GrantAllPermToExtWhenNoPolicy.java
  • sun/security/provider/PolicyParser/PrincipalExpansionError.java

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8348406: Remove tests GrantAllPermToExtWhenNoPolicy and PrincipalExpansionError from problem list (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23275/head:pull/23275
$ git checkout pull/23275

Update a local copy of the PR:
$ git checkout pull/23275
$ git pull https://git.openjdk.org/jdk.git pull/23275/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23275

View PR using the GUI difftool:
$ git pr show -t 23275

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23275.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2025

👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8348406: Remove tests GrantAllPermToExtWhenNoPolicy and PrincipalExpansionError from problem list

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 228 new commits pushed to the master branch:

  • 3ebf889: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c
  • d9d2e19: 8348365: Bad format string in CLDRDisplayNamesTest
  • 59e7509: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests
  • 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
  • cba0f78: 8348387: Add fixpath if needed for user-supplied tools
  • 44e5cca: 8348391: Keep case if possible for TOPDIR
  • 7460a0a: 8348392: Make claims "other matches are possible" even when that is not true
  • 5cc690d: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures
  • c00557f: 8345049: Remove the jmx.tabular.data.hash.map compatibility property
  • 8b46db0: 8345045: Remove the jmx.remote.x.buffer.size JMX notification property
  • ... and 218 more: https://git.openjdk.org/jdk/compare/d66737ea1cfd92bcb208ded4e64822d12760205d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title JDK-8348406: Remove tests GrantAllPermToExtWhenNoPolicy and PrincipalExpansionError from problem list 8348406: Remove tests GrantAllPermToExtWhenNoPolicy and PrincipalExpansionError from problem list Jan 23, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@myankelev To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@myankelev
Copy link
Member Author

/label security

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@myankelev
The security label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jan 23, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 23, 2025
@myankelev
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@myankelev
Your change (at version 3692af5) is now ready to be sponsored by a Committer.

@rhalade
Copy link
Member

rhalade commented Jan 23, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

Going to push as commit 356e2a8.
Since your change was applied there have been 228 commits pushed to the master branch:

  • 3ebf889: 8348327: Incorrect march flag when building libsleef/vector_math_neon.c
  • d9d2e19: 8348365: Bad format string in CLDRDisplayNamesTest
  • 59e7509: 8348301: Remove unused Reference.waitForReferenceProcessing break-ins in tests
  • 605b53e: 8348299: Update List/ItemEventTest/ItemEventTest.java
  • cba0f78: 8348387: Add fixpath if needed for user-supplied tools
  • 44e5cca: 8348391: Keep case if possible for TOPDIR
  • 7460a0a: 8348392: Make claims "other matches are possible" even when that is not true
  • 5cc690d: 8347994: Add additional diagnostics to macOS failure handler to assist with diagnosing MCast test failures
  • c00557f: 8345049: Remove the jmx.tabular.data.hash.map compatibility property
  • 8b46db0: 8345045: Remove the jmx.remote.x.buffer.size JMX notification property
  • ... and 218 more: https://git.openjdk.org/jdk/compare/d66737ea1cfd92bcb208ded4e64822d12760205d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 23, 2025
@openjdk openjdk bot closed this Jan 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@rhalade @myankelev Pushed as commit 356e2a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants