Skip to content

8184352: Remove Sun provider information from KeyPairGenerator javadoc#23280

Closed
blperez01 wants to merge 4 commits intoopenjdk:masterfrom
blperez01:JDK-8184352
Closed

8184352: Remove Sun provider information from KeyPairGenerator javadoc#23280
blperez01 wants to merge 4 commits intoopenjdk:masterfrom
blperez01:JDK-8184352

Conversation

@blperez01
Copy link
Contributor

@blperez01 blperez01 commented Jan 23, 2025

Removed algorithm-specific information from KeyPairGenerator class description and instead linked out to the Sun Provider documentation


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8184352: Remove Sun provider information from KeyPairGenerator javadoc (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23280/head:pull/23280
$ git checkout pull/23280

Update a local copy of the PR:
$ git checkout pull/23280
$ git pull https://git.openjdk.org/jdk.git pull/23280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23280

View PR using the GUI difftool:
$ git pr show -t 23280

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23280.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 23, 2025

👋 Welcome back bperez! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@blperez01 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8184352: Remove Sun provider information from KeyPairGenerator javadoc

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 141 new commits pushed to the master branch:

  • bad39b6: 8348610: GenShen: TestShenandoahEvacuationInformationEvent failed with setRegions >= regionsFreed: expected 1 >= 57
  • 250ff86: 8349000: Performance improvement for Currency.isPastCutoverDate(String)
  • ee4caa4: 8349106: Change ChaCha20 intrinsic to use quarter-round parallel implementation on aarch64
  • b985347: 8348349: Refactor CDSConfig::is_dumping_heap()
  • beb43e2: 8349343: Add missing copyright messages in FFM benchmarks
  • e91a6ec: 8347489: RISC-V: Misaligned memory access with COH
  • d699aba: 8349135: Add tests for HttpRequest.Builder.copy()
  • 81126c2: 8349238: Some more FFM benchmarks are broken
  • beae884: 8349150: Support precompiled headers on AIX
  • c545a3e: 8346774: Use Predicate classes instead of Node classes
  • ... and 131 more: https://git.openjdk.org/jdk/compare/356e2a8f48679ea31f1483cf60803818934fc53f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 23, 2025
@openjdk
Copy link

openjdk bot commented Jan 23, 2025

@blperez01 The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 23, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 23, 2025

Webrevs

Copy link
Member

@seanjmullan seanjmullan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need copyright update.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 4, 2025
@blperez01
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 4, 2025

Going to push as commit 9d23de5.
Since your change was applied there have been 142 commits pushed to the master branch:

  • d222c18: 8349107: Remove RMI finalizers
  • bad39b6: 8348610: GenShen: TestShenandoahEvacuationInformationEvent failed with setRegions >= regionsFreed: expected 1 >= 57
  • 250ff86: 8349000: Performance improvement for Currency.isPastCutoverDate(String)
  • ee4caa4: 8349106: Change ChaCha20 intrinsic to use quarter-round parallel implementation on aarch64
  • b985347: 8348349: Refactor CDSConfig::is_dumping_heap()
  • beb43e2: 8349343: Add missing copyright messages in FFM benchmarks
  • e91a6ec: 8347489: RISC-V: Misaligned memory access with COH
  • d699aba: 8349135: Add tests for HttpRequest.Builder.copy()
  • 81126c2: 8349238: Some more FFM benchmarks are broken
  • beae884: 8349150: Support precompiled headers on AIX
  • ... and 132 more: https://git.openjdk.org/jdk/compare/356e2a8f48679ea31f1483cf60803818934fc53f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 4, 2025
@openjdk openjdk bot closed this Feb 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 4, 2025
@openjdk
Copy link

openjdk bot commented Feb 4, 2025

@blperez01 Pushed as commit 9d23de5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

2 participants