Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option #233

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Sep 18, 2020

The list of client test groups in "TEST.groups" is synchronized with the list of othervm.dirs in "TEST.ROOT"


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/233/head:pull/233
$ git checkout pull/233

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 18, 2020

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@mrserb The following label will be automatically applied to this pull request: core-libs.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the core-libs label Sep 18, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 18, 2020

/label remove core-libs

@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 18, 2020

/label add awt

@openjdk openjdk bot removed the core-libs label Sep 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@mrserb
The core-libs label was successfully removed.

@openjdk openjdk bot added the awt label Sep 18, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@mrserb
The awt label was successfully added.

@mrserb mrserb marked this pull request as ready for review Sep 18, 2020
@openjdk openjdk bot added the rfr label Sep 18, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 18, 2020

Webrevs

Copy link
Contributor

@shipilev shipilev left a comment

There seems to be the single test in that package, DefaultMenuBarTest.java. It sets system properties and thus is safer to run in othervm indeed.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 18, 2020

@mrserb This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253317: The "com/apple/eawt" is missed in the "othervm.dirs" config option

Reviewed-by: shade
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 14 commits pushed to the master branch:

  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • d35b117: 8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag
  • f37c34d: 8253270: Limit fastdebug inlining in G1 evacuation
  • 8904420: 8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc
  • 52c28b8: 8253239: Disable VS warning C4307
  • 05572e8: 8253350: Remove unimplemented SharedRuntime::clean_*_entry
  • 43019a0: 8253345: Remove unimplemented Arguments::lookup_logging_aliases
  • 6e9efff: 8253344: Remove unimplemented Arguments::check_gc_consistency
  • 83b2411: 8253342: Fix typos in String.transform
  • 86a1640: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/2c3a37c6d7638dc1a3318d9c5309516a1edfb590...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate f55dd9d40ed4dc03d96c06cd283c9aae814daec4.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 18, 2020
@mrserb
Copy link
Member Author

@mrserb mrserb commented Sep 19, 2020

/integrate

@openjdk openjdk bot closed this Sep 19, 2020
@openjdk openjdk bot added integrated and removed ready labels Sep 19, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 19, 2020

@mrserb Since your change was applied there have been 14 commits pushed to the master branch:

  • f55dd9d: 8251548: Remove unnecessary explicit initialization of volatile variables in security-libs code
  • d35b117: 8253361: Shenandoah: runtime barrier does not honor ShenandoahSelfFixing flag
  • f37c34d: 8253270: Limit fastdebug inlining in G1 evacuation
  • 8904420: 8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc
  • 52c28b8: 8253239: Disable VS warning C4307
  • 05572e8: 8253350: Remove unimplemented SharedRuntime::clean_*_entry
  • 43019a0: 8253345: Remove unimplemented Arguments::lookup_logging_aliases
  • 6e9efff: 8253344: Remove unimplemented Arguments::check_gc_consistency
  • 83b2411: 8253342: Fix typos in String.transform
  • 86a1640: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses
  • ... and 4 more: https://git.openjdk.java.net/jdk/compare/2c3a37c6d7638dc1a3318d9c5309516a1edfb590...master

Your commit was automatically rebased without conflicts.

Pushed as commit 22f7af7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr label Sep 19, 2020
@mrserb mrserb deleted the JDK-8253317 branch Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awt integrated
2 participants