Skip to content

8348561: Add aarch64 intrinsics for ML-DSA #23300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 13 commits into from
Closed

8348561: Add aarch64 intrinsics for ML-DSA #23300

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
e40e260
8348561: Add aarch64 intrinsics for ML-DSA
ferakocz Jan 10, 2025
eb7cc43
fixing whitespace errors
ferakocz Jan 27, 2025
3615163
Use SHA3Parallel for matrix generation
ferakocz Jan 30, 2025
5630fd1
merging master
ferakocz Jan 30, 2025
9f7c4a2
removed debugging code
ferakocz Feb 3, 2025
9a3a944
Adding comments + some code reorganization
ferakocz Feb 4, 2025
28b1cf7
renaming a couple of functions
ferakocz Feb 10, 2025
bc1e089
Fixed copyright years
ferakocz Feb 20, 2025
74c1c28
Added comments suggested by Andrew Dinn
ferakocz Feb 20, 2025
54373d5
Accepting suggested change from Andrew Dinn
ferakocz Feb 20, 2025
62d2a3d
Changed aarch64-asmtest.py as suggested by Bhavana-Kilambi
ferakocz Feb 26, 2025
aa0570d
Added more comments, mainly as suggested by Andrew Dinn
ferakocz Feb 26, 2025
d82dfb2
Merged master.
ferakocz Feb 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions src/hotspot/cpu/aarch64/stubRoutines_aarch64.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,11 +40,6 @@ static bool returns_to_call_stub(address return_pc) {
_ ## blob_name ## _code_size = size,

enum platform_dependent_constants {
// simply increase sizes if too small (assembler will crash if too small)
// _initial_stubs_code_size = 10000,
// _continuation_stubs_code_size = 2000,
// _compiler_stubs_code_size = 80000 ZGC_ONLY(+10000),
// _final_stubs_code_size = 20000 ZGC_ONLY(+100000)
STUBGEN_ARCH_BLOBS_DO(DEFINE_BLOB_SIZE)
};

Expand Down
2 changes: 0 additions & 2 deletions src/hotspot/cpu/aarch64/vm_version_aarch64.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -691,7 +691,6 @@ void VM_Version::print_platform_virtualization_info(outputStream* st) {
void VM_Version::initialize_cpu_information(void) {
// do nothing if cpu info has been initialized
if (_initialized) {
fprintf(stderr, "_features_string = \"%s\"", _features_string);
return;
}

Expand All @@ -704,7 +703,6 @@ void VM_Version::initialize_cpu_information(void) {
get_compatible_board(_cpu_desc + desc_len, CPU_DETAILED_DESC_BUF_SIZE - desc_len);
desc_len = (int)strlen(_cpu_desc);
snprintf(_cpu_desc + desc_len, CPU_DETAILED_DESC_BUF_SIZE - desc_len, " %s", _features_string);
fprintf(stderr, "_features_string = \"%s\"", _features_string);

_initialized = true;
}
18 changes: 0 additions & 18 deletions src/hotspot/share/opto/library_call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,24 +232,6 @@ bool LibraryCallKit::try_to_inline(int predicate) {
}
assert(merged_memory(), "");

if(intrinsic_id() == vmIntrinsics::_digestBase_implCompressMB) {
fprintf(stderr, "try_to_inline call for _digestBase_implCompressMB\n");
} else if(intrinsic_id() == vmIntrinsics::_sha3_implCompress) {
fprintf(stderr, "try_to_inline call for _sha3_implCompress\n");
} else if(intrinsic_id() == vmIntrinsics::_double_keccak) {
fprintf(stderr, "try_to_inline call for _double_keccak\n");
} else if(intrinsic_id() == vmIntrinsics::_dilithiumAlmostNtt) {
fprintf(stderr, "try_to_inline call for _dilithiumAlmostNtt\n");
} else if(intrinsic_id() == vmIntrinsics::_dilithiumAlmostInverseNtt) {
fprintf(stderr, "try_to_inline call for _dilithiumAlmostInverseNtt\n");
} else if(intrinsic_id() == vmIntrinsics::_dilithiumNttMult) {
fprintf(stderr, "try_to_inline call for _dilithiumNttMult\n");
} else if(intrinsic_id() == vmIntrinsics::_dilithiumMontMulByConstant) {
fprintf(stderr, "try_to_inline call for _dilithiumMontMulByConstant\n");
} else if(intrinsic_id() == vmIntrinsics::_dilithiumDecomposePoly) {
fprintf(stderr, "try_to_inline call for _dilithiumDecomposePoly\n");
}

switch (intrinsic_id()) {
case vmIntrinsics::_hashCode: return inline_native_hashcode(intrinsic()->is_virtual(), !is_static);
case vmIntrinsics::_identityHashCode: return inline_native_hashcode(/*!virtual*/ false, is_static);
Expand Down