Skip to content

8348420: Shenandoah: Check is_reserved before using ReservedSpace instances #23308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
earthling-amzn wants to merge 1 commit into from
Closed

8348420: Shenandoah: Check is_reserved before using ReservedSpace instances #23308

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/hotspot/share/gc/shenandoah/shenandoahHeap.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,11 @@ static ReservedSpace reserve(size_t size, size_t preferred_page_size) {
size = align_up(size, alignment);
}

return MemoryReserver::reserve(size, alignment, preferred_page_size);
const ReservedSpace reserved = MemoryReserver::reserve(size, alignment, preferred_page_size);
if (!reserved.is_reserved()) {
vm_exit_during_initialization("Could not reserve space");
}
return reserved;
}

jint ShenandoahHeap::initialize() {
Expand Down Expand Up @@ -386,8 +390,9 @@ jint ShenandoahHeap::initialize() {

if (_collection_set == nullptr) {
cset_rs = MemoryReserver::reserve(cset_size, cset_align, os::vm_page_size());

// Maybe Shenandoah wants to check the the memory got reserved here?
if (!cset_rs.is_reserved()) {
vm_exit_during_initialization("Cannot reserve memory for collection set");
}

_collection_set = new ShenandoahCollectionSet(this, cset_rs, sh_rs.base());
}
Expand Down