8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support#23314
8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support#23314sspitsyn wants to merge 3 commits intoopenjdk:masterfrom
Conversation
… jvmti missing some virtual thread support
|
👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into |
|
@sspitsyn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 46 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetLocalVariable/setlocal001.java
Outdated
Show resolved
Hide resolved
test/hotspot/jtreg/vmTestbase/nsk/jvmti/SetLocalVariable/setlocal001/setlocal001.cpp
Outdated
Show resolved
Hide resolved
|
Chris and Leonid, thank you for review! |
|
/integrate |
|
Going to push as commit fb0f2d2.
Your commit was automatically rebased without conflicts. |
Some
nsk.jvmtitests are failed with the-testThreadFactory:Virtual, so they are listed in thetest/hotspot/jtreg/ProblemList-Virtual.txt.The fix is to adjust tests expectations regarding tested virtual threads to expect error
JVMTI_ERROR_OPAQUE_FRAME.Testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23314/head:pull/23314$ git checkout pull/23314Update a local copy of the PR:
$ git checkout pull/23314$ git pull https://git.openjdk.org/jdk.git pull/23314/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23314View PR using the GUI difftool:
$ git pr show -t 23314Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23314.diff
Using Webrev
Link to Webrev Comment