Skip to content

8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support#23314

Closed
sspitsyn wants to merge 3 commits intoopenjdk:masterfrom
sspitsyn:c6
Closed

8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support#23314
sspitsyn wants to merge 3 commits intoopenjdk:masterfrom
sspitsyn:c6

Conversation

@sspitsyn
Copy link
Contributor

@sspitsyn sspitsyn commented Jan 27, 2025

Some nsk.jvmti tests are failed with the -testThreadFactory:Virtual, so they are listed in the test/hotspot/jtreg/ProblemList-Virtual.txt.

The fix is to adjust tests expectations regarding tested virtual threads to expect error JVMTI_ERROR_OPAQUE_FRAME.

Testing:

  • Ran mach5 tiers 1-5

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23314/head:pull/23314
$ git checkout pull/23314

Update a local copy of the PR:
$ git checkout pull/23314
$ git pull https://git.openjdk.org/jdk.git pull/23314/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23314

View PR using the GUI difftool:
$ git pr show -t 23314

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23314.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2025

👋 Welcome back sspitsyn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 27, 2025

@sspitsyn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support

Reviewed-by: cjplummer, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 46 new commits pushed to the master branch:

  • cbe9ec5: 8348905: Add support to specify the JDK for compiling Jtreg tests
  • 6b581d2: 8347997: assert(false) failed: EA: missing memory path
  • 4662363: 8348687: [BACKOUT] C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat
  • d266ca9: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
  • cbc89a7: 8348898: Remove unused OctalDigits to clean up code
  • 96fefed: 8319850: PrintInlining should print which methods are late inlines
  • 51cce6e: 8318577: Windows Look-and-Feel JProgressBarUI does not render correctly on 2x UI scale
  • 6bfae3a: 8333386: TestAbortOnVMOperationTimeout test fails for client VM
  • f98d9a3: 8348870: Eliminate array bound checks in DecimalDigits
  • fe6d9ab: 8348582: Set -fstack-protector when building with clang
  • ... and 36 more: https://git.openjdk.org/jdk/compare/175e58b2e321b779276a9a98a5e72cedb9638d0c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 27, 2025
@openjdk
Copy link

openjdk bot commented Jan 27, 2025

@sspitsyn The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jan 27, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2025

Webrevs

@sspitsyn sspitsyn changed the title 8300708: some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support 8300708: Some nsk jvmti tests fail with virtual thread wrapper due to jvmti missing some virtual thread support Jan 28, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 29, 2025
@sspitsyn
Copy link
Contributor Author

Chris and Leonid, thank you for review!

@sspitsyn
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

Going to push as commit fb0f2d2.
Since your change was applied there have been 51 commits pushed to the master branch:

  • bb528d5: 8348567: [ASAN] Memory access partially overflows by NativeCallStack
  • e0c2cb4: 8348663: [AIX] clang pollutes the burned-in library search paths of the generated executables
  • 14136f8: 8347564: ZGC: Crash in DependencyContext::clean_unloading_dependents
  • 04c24f1: 8347779: sun/tools/jhsdb/HeapDumpTestWithActiveProcess.java fails with Unable to deduce type of thread from address
  • d985b31: 8342096: Popup menus that request focus are not shown on Linux with Wayland
  • cbe9ec5: 8348905: Add support to specify the JDK for compiling Jtreg tests
  • 6b581d2: 8347997: assert(false) failed: EA: missing memory path
  • 4662363: 8348687: [BACKOUT] C2: Non-fluid StringBuilder pattern bails out in OptoStringConcat
  • d266ca9: 8348752: Enable -XX:+AOTClassLinking by default when -XX:AOTMode is specified
  • cbc89a7: 8348898: Remove unused OctalDigits to clean up code
  • ... and 41 more: https://git.openjdk.org/jdk/compare/175e58b2e321b779276a9a98a5e72cedb9638d0c...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2025
@openjdk openjdk bot closed this Jan 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@sspitsyn Pushed as commit fb0f2d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sspitsyn sspitsyn deleted the c6 branch January 30, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants