Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate() #2333

Closed

Conversation

tschatzl
Copy link
Contributor

@tschatzl tschatzl commented Feb 1, 2021

Hi all,

can I have reviews for this change that removes parallel handling in CardTableRS::younger_refs_in_space_iterate as it is always called with n_threads <= 1, making the parallel code handling there obsolete.

A larger cleanup of CardTableRS will follow in JDK-8234534.

Testing:
tier1,2


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2333/head:pull/2333
$ git checkout pull/2333

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Feb 1, 2021

/label hotspot-gc

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 1, 2021

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added rfr hotspot-gc labels Feb 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@tschatzl
The hotspot-gc label was successfully added.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2021

Webrevs

Copy link
Contributor

@kstefanj kstefanj left a comment

Looks good.

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260643: Remove parallel version handling in CardTableRS::younger_refs_in_space_iterate()

Reviewed-by: ayang, sjohanss

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 80760a3: 8260669: Missing quotes in fixpath.sh
  • c0cde7d: 8259814: test/jdk/tools/jlink/plugins/CompressorPluginTest.java has compilation issues

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 1, 2021
@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Feb 2, 2021

Thanks @kstefanj @albertnetymk for your reviews.

/integrate

@tschatzl
Copy link
Contributor Author

@tschatzl tschatzl commented Feb 2, 2021

Fwiw I re-ran tier1+2 with no issues

@openjdk openjdk bot closed this Feb 2, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 2, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 2, 2021

@tschatzl Since your change was applied there have been 15 commits pushed to the master branch:

  • ddd2951: 8260571: Add PrintMetaspaceStatistics to print metaspace statistics upon VM exit
  • fe407cf: 8260420: C2 compilation fails with assert(found_sfpt) failed: no node in loop that's not input to safepoint
  • 474dba2: 8257086: Clarify differences between {Float, Double}.equals and ==
  • 54e7a64: 8260576: Typo in compiler/runtime/safepoints/TestRegisterRestoring.java
  • a6d9505: 8260864: ProblemList two security/krb5 tests on Linux
  • 9880c4c: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java
  • 55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()
  • b6a7367: 8260349: Cannot programmatically retrieve Metaspace max set via JAVA_TOOL_OPTIONS
  • 50f9a70: 8217327: G1 Post-Cleanup region liveness printing should not print out-of-date efficiency
  • e963ebd: 8260004: Shenandoah: Rename ShenandoahMarkCompact to ShenandoahFullGC
  • ... and 5 more: https://git.openjdk.java.net/jdk/compare/aec037721cf8990c3f7c4364730812447e0811e1...master

Your commit was automatically rebased without conflicts.

Pushed as commit 288a4fe.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@tschatzl tschatzl deleted the 8260643-younger-refs-iterate branch Feb 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc integrated
3 participants