Skip to content

8348631: Crash in PredictedCallGenerator::generate after JDK-8347006 #23331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

8348631: Crash in PredictedCallGenerator::generate after JDK-8347006 #23331

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f791c58
8348631: Crash in PredictedCallGenerator::generate after JDK-8347006
TobiHartmann Jan 28, 2025
8bde5df
Fix
TobiHartmann Jan 28, 2025
4cf7f86
Trailing ws
TobiHartmann Jan 28, 2025
54fd389
Added comment
TobiHartmann Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/hotspot/share/opto/library_call.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4303,6 +4303,8 @@ Node* LibraryCallKit::generate_array_guard_common(Node* kls, RegionNode* region,
// Keep track of the fact that 'obj' is an array to prevent
// array specific accesses from floating above the guard.
Node* cast = _gvn.transform(new CastPPNode(is_array_ctrl, *obj, TypeAryPtr::BOTTOM));
// Check for top because in rare cases, the type system can determine that
// the object can't be an array but the layout helper check is not folded.
if (!cast->is_top()) {
*obj = cast;
}
Expand Down