8349157: Unnecessary Hashtable usage in XKeysym.javaKeycode2KeysymHash

[turbanoff]

There is a field sun.awt.X11.XKeysym#javaKeycode2KeysymHash which uses legacy Hashtable class.
As this map is read-only and all its content is initialized in <clinit> we can safely use immutable Map instead.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349157: Unnecessary Hashtable usage in XKeysym.javaKeycode2KeysymHash (Enhancement - P5)

Reviewers

• Alexey Ivanov (@aivanov-jdk - Reviewer)
• Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23347/head:pull/23347
$ git checkout pull/23347

Update a local copy of the PR:
$ git checkout pull/23347
$ git pull https://git.openjdk.org/jdk.git pull/23347/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23347

View PR using the GUI difftool:
$ git pr show -t 23347

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23347.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349157: Unnecessary Hashtable usage in XKeysym.javaKeycode2KeysymHash

Reviewed-by: aivanov, serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4127 new commits pushed to the master branch:

• 1baf516: 8371628: C2: add a test case for the arraycopy changes in JDK-8297933
• 7733632: 8369206: jpackage should not set R/O permission on app launchers
• eaddefb: 8371753: compiler/c2/cr7200264/TestIntVect.java fails IR verification
• ... and 4124 more: https://git.openjdk.org/jdk/compare/fff97d6d9ae136121f042c760fed2ece431f9473...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4a262cf4)

[bridgekeeper]

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[bridgekeeper]

@turbanoff This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

[aivanov-jdk]

Looks reasonable to me. I'd approve it.

[turbanoff]

/open

[openjdk]

@turbanoff This pull request is now open

[aivanov-jdk]

I submitted a test job.

[aivanov-jdk]

The tests are green.

[turbanoff]

/integrate

[openjdk]

Going to push as commit 69e3024.
Since your change was applied there have been 4158 commits pushed to the master branch:

• 970533d: 8371779: Replace MemTagBitmap with ResourceBitMap
• d032b28: 8371894: Minor style fixes in AOT/CDS code
• 8690d26: 8268613: jar --validate should check inital entries of a JAR file
• ... and 4155 more: https://git.openjdk.org/jdk/compare/fff97d6d9ae136121f042c760fed2ece431f9473...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit 69e3024.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.