8349039: Adjust exception No type named <ThreadType> in database

[MBaesken]

We should the exception message from
Caused by: java.lang.RuntimeException: No type named "DeoptimizeObjectsALotThread" in database
to
Caused by: java.lang.RuntimeException: No type named "DeoptimizeObjectsALotThread" present in type database

(like we have in some other exceptions in the same class)

error was (from JDK-8348800) :
serviceability/sa/CDSJMapClstats.java

at jdk.hotspot.agent/sun.jvm.hotspot.runtime.Threads.createJavaThreadWrapper(Threads.java:196)
at jdk.hotspot.agent/sun.jvm.hotspot.runtime.Threads.getJavaThreadAt(Threads.java:178)
at jdk.hotspot.agent/sun.jvm.hotspot.oops.ObjectHeap.collectLiveRegions(ObjectHeap.java:320)
at jdk.hotspot.agent/sun.jvm.hotspot.oops.ObjectHeap.iterateSubtypes(ObjectHeap.java:216)
at jdk.hotspot.agent/sun.jvm.hotspot.oops.ObjectHeap.iterateObjectsOfKlass(ObjectHeap.java:116)
at jdk.hotspot.agent/sun.jvm.hotspot.oops.ObjectHeap.iterateObjectsOfKlass(ObjectHeap.java:128)
at jdk.hotspot.agent/sun.jvm.hotspot.tools.ClassLoaderStats.printClassLoaderStatistics(ClassLoaderStats.java:95)
at jdk.hotspot.agent/sun.jvm.hotspot.tools.ClassLoaderStats.run(ClassLoaderStats.java:78)
at jdk.hotspot.agent/sun.jvm.hotspot.tools.JMap.run(JMap.java:121)
at jdk.hotspot.agent/sun.jvm.hotspot.tools.Tool.startInternal(Tool.java:278)
at jdk.hotspot.agent/sun.jvm.hotspot.tools.Tool.start(Tool.java:241)
at jdk.hotspot.agent/sun.jvm.hotspot.tools.Tool.execute(Tool.java:134)
at jdk.hotspot.agent/sun.jvm.hotspot.tools.JMap.main(JMap.java:202)
at jdk.hotspot.agent/sun.jvm.hotspot.SALauncher.runJMAP(SALauncher.java:344)
at jdk.hotspot.agent/sun.jvm.hotspot.SALauncher.main(SALauncher.java:507)
Caused by: java.lang.RuntimeException: No type named "DeoptimizeObjectsALotThread" in database
at jdk.hotspot.agent/sun.jvm.hotspot.types.basic.BasicTypeDataBase.lookupType(BasicTypeDataBase.java:86)
at jdk.hotspot.agent/sun.jvm.hotspot.HotSpotTypeDataBase.lookupType(HotSpotTypeDataBase.java:137)
at jdk.hotspot.agent/sun.jvm.hotspot.types.basic.BasicTypeDataBase.lookupType(BasicTypeDataBase.java:80)
at jdk.hotspot.agent/sun.jvm.hotspot.runtime.VirtualConstructor.instantiateWrapperFor(VirtualConstructor.java:75)
at jdk.hotspot.agent/sun.jvm.hotspot.runtime.Threads.createJavaThreadWrapper(Threads.java:192)

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349039: Adjust exception No type named <ThreadType> in database (Bug - P4)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)
• Chris Plummer (@plummercj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23365/head:pull/23365
$ git checkout pull/23365

Update a local copy of the PR:
$ git checkout pull/23365
$ git pull https://git.openjdk.org/jdk.git pull/23365/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23365

View PR using the GUI difftool:
$ git pr show -t 23365

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23365.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349039: Adjust exception No type named <ThreadType> in database

Reviewed-by: kevinw, cjplummer

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

• f05c53c: 8347949: Currency method to stream available Currencies
• cc775b1: 8348648: Unnecessary Hashtable usage in javax.swing.text.html.CSS.LengthUnit
• 06ebb17: 8349002: GenShen: Deadlock during shutdown
• 1ac2d6e: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
• 0cae888: 8349003: NativeCallStack::print_on() output is unreadable
• fdfb68c: 8344168: Change Unsafe base offset from int to long
• 5d5b294: 8349070: Fix riscv and ppc build errors caused by JDK-8343767
• 3f8a875: 8348880: Replace ConcurrentMap with AtomicReferenceArray for ZoneOffset.QUARTER_CACHE
• fac63d4: 8348668: Prevent first resource cleanup in confined arena from escaping
• 2efb6aa: 8345314: Add a red–black tree as a utility data structure
• ... and 5 more: https://git.openjdk.org/jdk/compare/bb528d5ad6f28e9c1bc4e283d40c70489465bd00...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4b0dcce0)

[kevinjwalls]

Making one exception message phrased like the two other similar examples in the same file.

[plummercj]

Looks good. Also is trivial.

[MBaesken]

Thanks for the reviews !

/integrate

[openjdk]

Going to push as commit 669f8c0.
Since your change was applied there have been 22 commits pushed to the master branch:

• 5a45de5: 8347989: Trees.getScope may crash for not-yet attributed source
• 2df9d5b: 8349040: Test compiler/inlining/LateInlinePrinting.java fails after JDK-8319850
• 03f5c33: 8349122: -XX:+AOTClassLinking is not compatible with jdwp
• 0d30b86: 8344581: [TESTBUG] java/awt/Robot/ScreenCaptureRobotTest.java failing on macOS
• cdc84ac: 8348890: Fix docs for -XX:AOT* options in java man page
• 8986cb2: 8331873: Improve/expand info in New API In on Help page
• d589a82: 8349101: Problemlist HeadlessMalfunctionTest.java
• f05c53c: 8347949: Currency method to stream available Currencies
• cc775b1: 8348648: Unnecessary Hashtable usage in javax.swing.text.html.CSS.LengthUnit
• 06ebb17: 8349002: GenShen: Deadlock during shutdown
• ... and 12 more: https://git.openjdk.org/jdk/compare/bb528d5ad6f28e9c1bc4e283d40c70489465bd00...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 669f8c0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.