Skip to content

Conversation

@honkar-jdk
Copy link
Contributor

@honkar-jdk honkar-jdk commented Jan 30, 2025

java/awt/Headless/HeadlessMalfunctionTest.java problemlisted as it fails after JDK-8336382 fix.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349101: Problemlist HeadlessMalfunctionTest.java (Sub-task - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23375/head:pull/23375
$ git checkout pull/23375

Update a local copy of the PR:
$ git checkout pull/23375
$ git pull https://git.openjdk.org/jdk.git pull/23375/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23375

View PR using the GUI difftool:
$ git pr show -t 23375

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23375.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 30, 2025

👋 Welcome back honkar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@honkar-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349101: Problemlist HeadlessMalfunctionTest.java

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 54 new commits pushed to the master branch:

  • f05c53c: 8347949: Currency method to stream available Currencies
  • cc775b1: 8348648: Unnecessary Hashtable usage in javax.swing.text.html.CSS.LengthUnit
  • 06ebb17: 8349002: GenShen: Deadlock during shutdown
  • 1ac2d6e: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
  • 0cae888: 8349003: NativeCallStack::print_on() output is unreadable
  • fdfb68c: 8344168: Change Unsafe base offset from int to long
  • 5d5b294: 8349070: Fix riscv and ppc build errors caused by JDK-8343767
  • 3f8a875: 8348880: Replace ConcurrentMap with AtomicReferenceArray for ZoneOffset.QUARTER_CACHE
  • fac63d4: 8348668: Prevent first resource cleanup in confined arena from escaping
  • 2efb6aa: 8345314: Add a red–black tree as a utility data structure
  • ... and 44 more: https://git.openjdk.org/jdk/compare/1916a7773f2083096e18b92d71d384453652c07d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@honkar-jdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@honkar-jdk
Copy link
Contributor Author

/label client

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@honkar-jdk
The client label was successfully added.

@honkar-jdk honkar-jdk changed the title Problemlist HeadlessMalfunctionTest.java JDK-8349101 : Problemlist HeadlessMalfunctionTest.java Jan 30, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 30, 2025
Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 30, 2025
@honkar-jdk
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 30, 2025

Going to push as commit d589a82.
Since your change was applied there have been 54 commits pushed to the master branch:

  • f05c53c: 8347949: Currency method to stream available Currencies
  • cc775b1: 8348648: Unnecessary Hashtable usage in javax.swing.text.html.CSS.LengthUnit
  • 06ebb17: 8349002: GenShen: Deadlock during shutdown
  • 1ac2d6e: 8349009: JVM fails to start when AOTClassLinking is used with unverifiable old classes
  • 0cae888: 8349003: NativeCallStack::print_on() output is unreadable
  • fdfb68c: 8344168: Change Unsafe base offset from int to long
  • 5d5b294: 8349070: Fix riscv and ppc build errors caused by JDK-8343767
  • 3f8a875: 8348880: Replace ConcurrentMap with AtomicReferenceArray for ZoneOffset.QUARTER_CACHE
  • fac63d4: 8348668: Prevent first resource cleanup in confined arena from escaping
  • 2efb6aa: 8345314: Add a red–black tree as a utility data structure
  • ... and 44 more: https://git.openjdk.org/jdk/compare/1916a7773f2083096e18b92d71d384453652c07d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 30, 2025
@openjdk openjdk bot closed this Jan 30, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 30, 2025
@openjdk
Copy link

openjdk bot commented Jan 30, 2025

@honkar-jdk Pushed as commit d589a82.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jan 30, 2025

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

client client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants