Skip to content

Conversation

@myankelev
Copy link
Member

@myankelev myankelev commented Jan 31, 2025

Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349151: Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23394/head:pull/23394
$ git checkout pull/23394

Update a local copy of the PR:
$ git checkout pull/23394
$ git pull https://git.openjdk.org/jdk.git pull/23394/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23394

View PR using the GUI difftool:
$ git pr show -t 23394

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23394.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2025

👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349151: Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test

Reviewed-by: weijun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 740 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade, @wangweij) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title JDK-8349151: Refactor test/java/security//cert/CertificateFactory/slowstream.sh to java test 8349151: Refactor test/java/security//cert/CertificateFactory/slowstream.sh to java test Jan 31, 2025
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2025
@openjdk
Copy link

openjdk bot commented Jan 31, 2025

@myankelev The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the security security-dev@openjdk.org label Jan 31, 2025
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2025

Webrevs

@seanjmullan
Copy link
Member

There's an extra '/' in the bug title, can you remove it?

@myankelev
Copy link
Member Author

myankelev commented Feb 11, 2025

There's an extra '/' in the bug title, can you remove it?

Sure, done

@myankelev myankelev changed the title 8349151: Refactor test/java/security//cert/CertificateFactory/slowstream.sh to java test 8349151: Refactor test/java/security/cert/CertificateFactory/slowstream.sh to java test Feb 11, 2025
@bridgekeeper
Copy link

bridgekeeper bot commented Mar 11, 2025

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@myankelev
Copy link
Member Author

Still needs a review

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 9, 2025

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@myankelev
Copy link
Member Author

Still needs a review

@openjdk openjdk bot added ready Pull request is ready to be integrated sponsor Pull request is ready to be sponsored labels May 16, 2025
@openjdk
Copy link

openjdk bot commented May 16, 2025

@myankelev
Your change (at version 763b07c) is now ready to be sponsored by a Committer.

@myankelev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented May 16, 2025

@myankelev
Your change (at version 763b07c) is now ready to be sponsored by a Committer.

@wangweij
Copy link
Contributor

/sponsor

@openjdk
Copy link

openjdk bot commented May 19, 2025

Going to push as commit fbc12be.
Since your change was applied there have been 758 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 19, 2025
@openjdk openjdk bot closed this May 19, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels May 19, 2025
@openjdk
Copy link

openjdk bot commented May 19, 2025

@wangweij @myankelev Pushed as commit fbc12be.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

5 participants