Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc #234

Closed
wants to merge 1 commit into from

Conversation

naotoj
Copy link
Member

@naotoj naotoj commented Sep 18, 2020

Hi,

Please review this simple doc fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/234/head:pull/234
$ git checkout pull/234

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2020

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@naotoj The following labels will be automatically applied to this pull request: core-libs i18n.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org labels Sep 18, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@naotoj This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253153: Mentioning of "hour-of-minute" in java.time.temporal.TemporalField JavaDoc

Reviewed-by: joehw, lancea, rriggs
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 10 commits pushed to the master branch:

  • 52c28b8: 8253239: Disable VS warning C4307
  • 05572e8: 8253350: Remove unimplemented SharedRuntime::clean_*_entry
  • 43019a0: 8253345: Remove unimplemented Arguments::lookup_logging_aliases
  • 6e9efff: 8253344: Remove unimplemented Arguments::check_gc_consistency
  • 83b2411: 8253342: Fix typos in String.transform
  • 86a1640: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses
  • 11c4ea9: 8253278: Refactor/cleanup oopDesc::*_klass_addr
  • 73c9088: 8249451: Unconditional exceptions clearing logic in compiler code should honor Async Exceptions.
  • 3ef2efb: 8252721: Nested classes in Swing APIs rely on default constructors
  • fd380d7: 8253274: The CycleDMImagetest brokes the system

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate 52c28b869293c8639228ff32ec8f8615955fe39d.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 18, 2020
@naotoj
Copy link
Member Author

naotoj commented Sep 18, 2020

/integrate

@openjdk openjdk bot closed this Sep 18, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 18, 2020
@openjdk
Copy link

openjdk bot commented Sep 18, 2020

@naotoj Since your change was applied there have been 10 commits pushed to the master branch:

  • 52c28b8: 8253239: Disable VS warning C4307
  • 05572e8: 8253350: Remove unimplemented SharedRuntime::clean_*_entry
  • 43019a0: 8253345: Remove unimplemented Arguments::lookup_logging_aliases
  • 6e9efff: 8253344: Remove unimplemented Arguments::check_gc_consistency
  • 83b2411: 8253342: Fix typos in String.transform
  • 86a1640: 8244505: G1 pause time ratio calculation does not consider Remark/Cleanup pauses
  • 11c4ea9: 8253278: Refactor/cleanup oopDesc::*_klass_addr
  • 73c9088: 8249451: Unconditional exceptions clearing logic in compiler code should honor Async Exceptions.
  • 3ef2efb: 8252721: Nested classes in Swing APIs rely on default constructors
  • fd380d7: 8253274: The CycleDMImagetest brokes the system

Your commit was automatically rebased without conflicts.

Pushed as commit 8904420.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
4 participants