Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java #2341

Closed
wants to merge 1 commit into from

Conversation

@dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 1, 2021

A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the
ProblemList. It was removed in error (see the bug for the details).


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2341/head:pull/2341
$ git checkout pull/2341

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Feb 1, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Feb 1, 2021

/label core-libs

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@dcubed-ojdk To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • 2d
  • awt
  • beans
  • build
  • compiler
  • core-libs
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah
  • sound
  • swing

@openjdk openjdk bot added the core-libs label Feb 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@dcubed-ojdk
The core-libs label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review Feb 1, 2021
@openjdk openjdk bot added the rfr label Feb 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 1, 2021

Webrevs

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Feb 1, 2021

@JimLaskey or @sundararajana - If either if you are on-line and can review this, I would
appreciate it. Jim, you reviewed it the last time I ProblemListed it. Sundar, you took the
test off the ProblemList before https://bugs.openjdk.java.net/browse/JDK-8247407 was
fixed so we have failures again.

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Feb 1, 2021

/label add hotspot-runtime

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

Copy link
Member

@dholmes-ora dholmes-ora left a comment

LGTM

@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Feb 1, 2021
@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Feb 1, 2021

@dholmes-ora - Thanks for the fast review!

@dcubed-ojdk
Copy link
Member Author

@dcubed-ojdk dcubed-ojdk commented Feb 1, 2021

/integrate

@openjdk openjdk bot closed this Feb 1, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Feb 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Feb 1, 2021

@dcubed-ojdk Since your change was applied there has been 1 commit pushed to the master branch:

  • 55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()

Your commit was automatically rebased without conflicts.

Pushed as commit 9880c4c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8260860 branch Feb 1, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 2, 2021

Mailing list message from Alan Bateman on core-libs-dev:

On 01/02/2021 22:13, Daniel D.Daugherty wrote:

A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java back on the
ProblemList. It was removed in error (see the bug for the details).

Something fishy here, Sundar ran the test 500 times on the 3 main
platforms before integrating. I asked him to do this because of
reliability issues with some of the jlink tests. linux-aarch64 was
missed in that testing and we do seem to have an issue there at least.

-Alan

@mlbridge
Copy link

@mlbridge mlbridge bot commented Feb 2, 2021

Mailing list message from daniel.daugherty at oracle.com on core-libs-dev:

On 2/2/21 2:46 AM, Alan Bateman wrote:

On 01/02/2021 22:13, Daniel D.Daugherty wrote:

A trivial fix to put tools/jlink/plugins/CompressorPluginTest.java
back on the
ProblemList. It was removed in error (see the bug for the details).

Something fishy here, Sundar ran the test 500 times on the 3 main
platforms before integrating. I asked him to do this because of
reliability issues with some of the jlink tests. linux-aarch64 was
missed in that testing and we do seem to have an issue there at least.

-Alan

I've updated https://bugs.openjdk.java.net/browse/JDK-8247407 with
a confidential comment and a link to bring up the recent test failures
in the JDK17 CI. The linux-aarch64 failures were pretty constant, the
linux-x64 and macOSX failures were intermittent.

I think this was a reasonable ProblemListing given the failures that
I observed yesterday.

Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants