Skip to content

Conversation

@vy
Copy link
Contributor

@vy vy commented Feb 3, 2025

Adds HttpRequest.Builder::copy tests to HttpRequestBuilderTest.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349135: Add tests for HttpRequest.Builder.copy() (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23415/head:pull/23415
$ git checkout pull/23415

Update a local copy of the PR:
$ git checkout pull/23415
$ git pull https://git.openjdk.org/jdk.git pull/23415/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23415

View PR using the GUI difftool:
$ git pr show -t 23415

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23415.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 3, 2025

👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@vy This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349135: Add tests for HttpRequest.Builder.copy()

Reviewed-by: jpai, dfuchs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 81126c2: 8349238: Some more FFM benchmarks are broken
  • beae884: 8349150: Support precompiled headers on AIX
  • c545a3e: 8346774: Use Predicate classes instead of Node classes
  • 7ea176d: 8349193: compiler/intrinsics/TestContinuationPinningAndEA.java missing @requires vm.continuations
  • 9b49597: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary
  • 43979fb: 8347428: Avoid using secret-key in specifications

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 3, 2025
@openjdk
Copy link

openjdk bot commented Feb 3, 2025

@vy The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Feb 3, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 3, 2025

Webrevs

@dfuch
Copy link
Member

dfuch commented Feb 4, 2025

Approved on the condition that the expected / actual mismatches are fixed.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 4, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 4, 2025
Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the updates Volkan. This looks good to me.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 4, 2025
@vy
Copy link
Contributor Author

vy commented Feb 4, 2025

Attached successful tier{1,2} test runs to the ticket.

@vy
Copy link
Contributor Author

vy commented Feb 4, 2025

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 4, 2025
@openjdk
Copy link

openjdk bot commented Feb 4, 2025

@vy
Your change (at version 9f7b054) is now ready to be sponsored by a Committer.

@jaikiran
Copy link
Member

jaikiran commented Feb 4, 2025

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 4, 2025

Going to push as commit d699aba.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 81126c2: 8349238: Some more FFM benchmarks are broken
  • beae884: 8349150: Support precompiled headers on AIX
  • c545a3e: 8346774: Use Predicate classes instead of Node classes
  • 7ea176d: 8349193: compiler/intrinsics/TestContinuationPinningAndEA.java missing @requires vm.continuations
  • 9b49597: 8334320: Replace vmTestbase/metaspace/share/TriggerUnloadingWithWhiteBox.java with ClassUnloadCommon from testlibrary
  • 43979fb: 8347428: Avoid using secret-key in specifications

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 4, 2025
@openjdk openjdk bot closed this Feb 4, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 4, 2025
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Feb 4, 2025
@openjdk
Copy link

openjdk bot commented Feb 4, 2025

@jaikiran @vy Pushed as commit d699aba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@vy vy deleted the HttpRequest-Builder-copy-Test branch February 4, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integrated Pull request has been integrated net net-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

3 participants