-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8349135: Add tests for HttpRequest.Builder.copy() #23415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back vyazici! A progress list of the required criteria for merging this PR into |
|
@vy This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 6 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dfuch, @jaikiran) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
|
Approved on the condition that the expected / actual mismatches are fixed. |
jaikiran
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the updates Volkan. This looks good to me.
|
Attached successful |
|
/integrate |
|
/sponsor |
|
Going to push as commit d699aba.
Your commit was automatically rebased without conflicts. |
Adds
HttpRequest.Builder::copytests toHttpRequestBuilderTest.Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23415/head:pull/23415$ git checkout pull/23415Update a local copy of the PR:
$ git checkout pull/23415$ git pull https://git.openjdk.org/jdk.git pull/23415/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23415View PR using the GUI difftool:
$ git pr show -t 23415Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23415.diff
Using Webrev
Link to Webrev Comment