Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8260864: ProblemList two security/krb5 tests on Linux #2342

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Feb 1, 2021

A trivial fix to ProblemList these two tests on Linux:

sun/security/krb5/auto/ReplayCacheTestProcWithMD5.java
sun/security/krb5/auto/ReplayCacheTestProc.java

We're rolling machines over to Linux 8.3 and these two tests are starting
to fail in the CI in Tier2 (so far). So we need to reduce the noise.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8260864: ProblemList two security/krb5 tests on Linux

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2342/head:pull/2342
$ git checkout pull/2342

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 1, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@dcubed-ojdk
Copy link
Member Author

/label security
/label hotspot-runtime

@openjdk openjdk bot added the security security-dev@openjdk.org label Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@dcubed-ojdk
The security label was successfully added.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review February 1, 2021 22:42
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 1, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 1, 2021

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dcubed-ojdk
Copy link
Member Author

@wangweij - just a heads up that I'm ProblemListing the two tests you said to "ignore".

@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260864: ProblemList two security/krb5 tests on Linux

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 1, 2021
@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the fast review!

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Feb 1, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 1, 2021
@openjdk
Copy link

openjdk bot commented Feb 1, 2021

@dcubed-ojdk Since your change was applied there have been 2 commits pushed to the master branch:

  • 9880c4c: 8260860: ProblemList tools/jlink/plugins/CompressorPluginTest.java
  • 55d62a5: 8213226: [TESTBUG] Reduce the usage of CDSTestUtils.executeAndLog()

Your commit was automatically rebased without conflicts.

Pushed as commit a6d9505.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dcubed-ojdk dcubed-ojdk deleted the JDK-8260864 branch February 1, 2021 22:59
@wangweij
Copy link
Contributor

wangweij commented Feb 1, 2021

@wangweij - just a heads up that I'm ProblemListing the two tests you said to "ignore".

No problem! Good idea!! Well done!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants