8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope #23437

sendaoYan · 2025-02-04T12:35:50Z

Hi all,

Several JMH tests fails "cannot access class jdk.internal.vm.ContinuationScope (in module java.base) because module java.base does not export jdk.internal.vm to unnamed module". This PR add VM option --add-exports=java.base/jdk.internal.vm=ALL-UNNAMED to fix the JMH test bug.

Change has been verified locally, test-fix only, no risk.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope (Bug - P4)

Reviewers

Alan Bateman (@AlanBateman - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23437/head:pull/23437
$ git checkout pull/23437

Update a local copy of the PR:
$ git checkout pull/23437
$ git pull https://git.openjdk.org/jdk.git pull/23437/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23437

View PR using the GUI difftool:
$ git pr show -t 23437

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23437.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-02-04T12:36:23Z

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-02-04T12:36:54Z

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 364 new commits pushed to the master branch:

e82031e: 8350756: C2 SuperWord Multiversioning: remove useless slow loop when the fast loop disappears
3626ac3: 8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile."
4bb3d81: 8351138: Running subset of gtests gets error printing result information
107ee87: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException
11a37c8: 8351165: Remove unused includes from vmStructs
c3b4819: 8351074: Disallow null prefix and suffix in DecimalFormat
6012e8d: 8350808: Small typos in JShell method SnippetEvent.toString()
661bd5b: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)
61d9ab9: 8350854: Include thread counts in safepoint logging
ea9e3cf: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
... and 354 more: https://git.openjdk.org/jdk/compare/7ea176d79c126c69cea5631d6542cd42bd8b11d9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-02-04T12:37:25Z

@sendaoYan To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

build
client
compiler
core-libs
graal
hotspot
hotspot-compiler
hotspot-gc
hotspot-jfr
hotspot-runtime
i18n
ide-support
javadoc
jdk
jmx
kulla
net
nio
security
serviceability
shenandoah

sendaoYan · 2025-02-04T12:38:25Z

/label add core-libs

openjdk · 2025-02-04T12:39:05Z

@sendaoYan
The core-libs label was successfully added.

mlbridge · 2025-02-04T12:42:47Z

Webrevs

01: Full - Incremental (6161b740)
00: Full (fe58200d)

AlanBateman · 2025-02-04T13:30:13Z

These are left over from early development, need to decide if they should be removed.

bridgekeeper · 2025-03-04T14:39:46Z

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

sendaoYan · 2025-03-04T15:33:16Z

Should we remove these JMH tests, or just fix the test bug and make tests run normally

AlanBateman · 2025-03-05T16:15:55Z

Should we remove these JMH tests, or just fix the test bug and make tests run normally

I think that would be best as they are left over from early development.

…test/micro/org/openjdk/bench/loom/obsolete/OneShot.java test/micro/org/openjdk/bench/loom/obsolete/Oscillation.java

sendaoYan · 2025-03-06T02:53:27Z

Should we remove these JMH tests, or just fix the test bug and make tests run normally

I think that would be best as they are left over from early development.

The related test files has been removed in this PR.

AlanBateman

Okay

sendaoYan · 2025-03-06T07:00:28Z

Thanks @AlanBateman

/integrate

openjdk · 2025-03-06T07:00:46Z

Going to push as commit 5c552a9.
Since your change was applied there have been 364 commits pushed to the master branch:

e82031e: 8350756: C2 SuperWord Multiversioning: remove useless slow loop when the fast loop disappears
3626ac3: 8204868: java/util/zip/ZipFile/TestCleaner.java still fails with "cleaner failed to clean zipfile."
4bb3d81: 8351138: Running subset of gtests gets error printing result information
107ee87: 8346954: [JMH] jdk.incubator.vector.MaskedLogicOpts fails due to IndexOutOfBoundsException
11a37c8: 8351165: Remove unused includes from vmStructs
c3b4819: 8351074: Disallow null prefix and suffix in DecimalFormat
6012e8d: 8350808: Small typos in JShell method SnippetEvent.toString()
661bd5b: 8343478: Remove unnecessary @SuppressWarnings annotations (core-libs)
61d9ab9: 8350854: Include thread counts in safepoint logging
ea9e3cf: 8281511: java/net/ipv6tests/UdpTest.java fails with checkTime failed
... and 354 more: https://git.openjdk.org/jdk/compare/7ea176d79c126c69cea5631d6542cd42bd8b11d9...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-03-06T07:00:52Z

@sendaoYan Pushed as commit 5c552a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope

fe58200

openjdk bot added the rfr Pull request is ready for review label Feb 4, 2025

openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 4, 2025

Remove test/micro/org/openjdk/bench/loom/obsolete/FreezeAndThaw.java …

6161b74

…test/micro/org/openjdk/bench/loom/obsolete/OneShot.java test/micro/org/openjdk/bench/loom/obsolete/Oscillation.java

AlanBateman approved these changes Mar 6, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Mar 6, 2025

openjdk bot added the integrated Pull request has been integrated label Mar 6, 2025

openjdk bot closed this Mar 6, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 6, 2025

sendaoYan deleted the jbs8349358 branch March 6, 2025 07:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope #23437

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope #23437

Uh oh!

sendaoYan commented Feb 4, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Feb 4, 2025

Uh oh!

openjdk bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Feb 4, 2025

Uh oh!

sendaoYan commented Feb 4, 2025

Uh oh!

openjdk bot commented Feb 4, 2025

Uh oh!

mlbridge bot commented Feb 4, 2025 •

edited

Loading

Uh oh!

AlanBateman commented Feb 4, 2025

Uh oh!

bridgekeeper bot commented Mar 4, 2025

Uh oh!

sendaoYan commented Mar 4, 2025

Uh oh!

AlanBateman commented Mar 5, 2025

Uh oh!

sendaoYan commented Mar 6, 2025

Uh oh!

AlanBateman left a comment

Uh oh!

sendaoYan commented Mar 6, 2025

Uh oh!

openjdk bot commented Mar 6, 2025

Uh oh!

openjdk bot commented Mar 6, 2025

Uh oh!

Uh oh!

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope #23437

8349358: [JMH] Cannot access class jdk.internal.vm.ContinuationScope #23437

Uh oh!

Conversation

sendaoYan commented Feb 4, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Feb 4, 2025

Uh oh!

openjdk bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Feb 4, 2025

Uh oh!

sendaoYan commented Feb 4, 2025

Uh oh!

openjdk bot commented Feb 4, 2025

Uh oh!

mlbridge bot commented Feb 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

AlanBateman commented Feb 4, 2025

Uh oh!

bridgekeeper bot commented Mar 4, 2025

Uh oh!

sendaoYan commented Mar 4, 2025

Uh oh!

AlanBateman commented Mar 5, 2025

Uh oh!

sendaoYan commented Mar 6, 2025

Uh oh!

AlanBateman left a comment

Choose a reason for hiding this comment

Uh oh!

sendaoYan commented Mar 6, 2025

Uh oh!

openjdk bot commented Mar 6, 2025

Uh oh!

openjdk bot commented Mar 6, 2025

Uh oh!

Uh oh!

sendaoYan commented Feb 4, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Feb 4, 2025 •

edited

Loading

mlbridge bot commented Feb 4, 2025 •

edited

Loading