8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

[myankelev]

Refactor the following to run fully in java:
test/java/security//Security/ClassLoaderDeadlock/ClassLoaderDeadlock.sh
test/java/security//Security/ClassLoaderDeadlock/Deadlock.sh

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java (Sub-task - P4)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)
• Sean Mullan (@seanjmullan - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23440/head:pull/23440
$ git checkout pull/23440

Update a local copy of the PR:
$ git checkout pull/23440
$ git pull https://git.openjdk.org/jdk.git pull/23440/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23440

View PR using the GUI difftool:
$ git pr show -t 23440

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23440.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myankelev! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@myankelev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349348: Refactor ClassLoaderDeadlock.sh and Deadlock.sh to run fully in java

Reviewed-by: jpai, mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 701 new commits pushed to the master branch:

• d63b561: 8353188: C1: Clean up x86 backend after 32-bit x86 removal
• d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
• 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
• 6d9ece7: 8351949: RISC-V: Cleanup and enable store-load peephole for membars
• 97ed536: 8346989: C2: deoptimization and re-execution cycle with Math.*Exact in case of frequent overflow
• 660b17a: 8350852: Implement JMH benchmark for sparse CodeCache
• 6d37e63: 8353753: Remove unnecessary forward declaration in oop.hpp
• 9bb804b: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java
• e17c399: 8353201: Open source Swing Tooltip tests - Set 2
• 9fcb06f: 8352997: Open source several Swing JTabbedPane tests
• ... and 691 more: https://git.openjdk.org/jdk/compare/964dd18fd2ba998e5c1efed48e15e516b0c22b19...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran, @seanjmullan) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@myankelev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (e1056f95)
• 01: Full - Incremental (92de4d99)
• 00: Full (0efada20)

[jaikiran]

Hello Mikhail, since we are updating these tests to move away from the shell tests, could you also see if the deadlock.jar file which has been committed into the repo, can be generated dynamically within the test itself. There are several ways we could do that and some other tests already have examples, but I think the main thing to look into is what exactly that (signed) jar contains to see if it is feasible to generate it dynamically.

[jaikiran]

Hello Mikhail, since we are updating these tests to move away from the shell tests, could you also see if the deadlock.jar file which has been committed into the repo, can be generated dynamically within the test itself.

I spoke to Mikhail about this and we decided that it's OK to leave it in the current form and think about it as a separate task for a future date.

[jaikiran]

Thank you for the updates, Mikhail. This looks good to me. Given the background of these tests, please have it approved from security-libs team too before integrating.

[myankelev]

Thank you for the updates, Mikhail. This looks good to me. Given the background of these tests, please have it approved from security-libs team too before integrating.

Thank you

[bridgekeeper]

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[myankelev]

Still requires a security-libs review

[seanjmullan]

The JBS issue should have a noreg-self label. Otherwise fix looks ok.

[myankelev]

The JBS issue should have a noreg-self label. Otherwise fix looks ok.

@seanjmullan thank you! I have updated the JBS issue.

[myankelev]

/integrate

[openjdk]

@myankelev
Your change (at version e1056f9) is now ready to be sponsored by a Committer.

[jaikiran]

/sponsor

[openjdk]

Going to push as commit 32d6d03.
Since your change was applied there have been 702 commits pushed to the master branch:

• 39549f8: 8352116: Deadlock with GCLocker and JVMTI after JDK-8192647
• d63b561: 8353188: C1: Clean up x86 backend after 32-bit x86 removal
• d1e91fc: 8353344: RISC-V: Detect and enable several extensions for debug builds
• 6abf4e6: 8353568: SEGV_BNDERR signal code adjust definition
• 6d9ece7: 8351949: RISC-V: Cleanup and enable store-load peephole for membars
• 97ed536: 8346989: C2: deoptimization and re-execution cycle with Math.*Exact in case of frequent overflow
• 660b17a: 8350852: Implement JMH benchmark for sparse CodeCache
• 6d37e63: 8353753: Remove unnecessary forward declaration in oop.hpp
• 9bb804b: 8338554: Fix inconsistencies in javadoc/doclet/testLinkOption/TestRedirectLinks.java
• e17c399: 8353201: Open source Swing Tooltip tests - Set 2
• ... and 692 more: https://git.openjdk.org/jdk/compare/964dd18fd2ba998e5c1efed48e15e516b0c22b19...master

Your commit was automatically rebased without conflicts.

[openjdk]

@jaikiran @myankelev Pushed as commit 32d6d03.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.