8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC

[roberttoyonaga]

Just a tiny test case fix. The test was previously checking the wrong events.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC (Bug - P4)

Reviewers

• Erik Gahlin (@egahlin - Reviewer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23445/head:pull/23445
$ git checkout pull/23445

Update a local copy of the PR:
$ git checkout pull/23445
$ git pull https://git.openjdk.org/jdk.git pull/23445/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23445

View PR using the GUI difftool:
$ git pr show -t 23445

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23445.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back roberttoyonaga! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@roberttoyonaga This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8276995: Bug in jdk.jfr.event.gc.collection.TestSystemGC

Reviewed-by: egahlin, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

• 7a0832f: 8349934: Wrong file regex for copyright header format check in .jcheck/conf
• 2a5d1da: 8349571: Remove JavaThreadFactory interface from SA
• 74e458b: 8349684: Remove SA core file tests from problem list for macosx-x64
• ba28119: 8348427: DeferredLintHandler API should use JCTree instead of DiagnosticPosition
• c5ac3c4: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore
• 336d0d8: 8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c
• 4b463ee: 8342103: C2 compiler support for Float16 type and associated scalar operations
• 332d87c: 8349859: Support static JDK in libfontmanager/freetypeScaler.c
• 73e1780: 8349836: G1: Improve group prediction log message
• ed17c55: 8349145: Make Class.getProtectionDomain() non-native
• ... and 86 more: https://git.openjdk.org/jdk/compare/bad39b6d8892ba9b86bc81bf01108a1df617defb...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@egahlin, @dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@roberttoyonaga The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (2a7ebdc6)
• 00: Full (8fa82737)

[roberttoyonaga]

/label add hotspot-jfr

[openjdk]

@roberttoyonaga
The hotspot-jfr label was successfully added.

[roberttoyonaga]

/label remove hotspot

[openjdk]

@roberttoyonaga
The hotspot label was successfully removed.

[dholmes-ora]

Seems good and trivial.

Thanks

[roberttoyonaga]

/integrate
Thanks!

[openjdk]

@roberttoyonaga
Your change (at version 8fa8273) is now ready to be sponsored by a Committer.

[roberttoyonaga]

/integrate

[openjdk]

@roberttoyonaga
Your change (at version 2a7ebdc) is now ready to be sponsored by a Committer.

[sendaoYan]

/sponsor

[openjdk]

Going to push as commit e80b76b.
Since your change was applied there have been 264 commits pushed to the master branch:

• 799ac52: 8314840: 3 gc/epsilon tests ignore external vm options
• 63e0fc4: 8350841: ProblemList jdk/incubator/vector/Long256VectorTests.java
• acc6f19: 8350614: [JMH] jdk.incubator.vector.VectorCommutativeOperSharingBenchmark fails
• 01bd7e4: 8350314: Shenandoah: Capture thread state sync times in GC timings
• 4522f12: 8349921: Crash in codeBuffer.cpp:1004: guarantee(sect->end() <= tend) failed: sanity
• e4d3c97: 8350111: [PPC] AsyncGetCallTrace crashes when called while handling SIGTRAP
• 885338b: 8323582: C2 SuperWord AlignVector: misaligned vector memory access with unaligned native memory
• bb48b73: 8350723: RISC-V: debug.cpp help() is missing riscv line for pns
• b29f8b0: 8350665: SIZE_FORMAT_HEX macro undefined in gtest
• 78c18cf: 8349399: GHA: Add static-jdk build on linux-x64
• ... and 254 more: https://git.openjdk.org/jdk/compare/bad39b6d8892ba9b86bc81bf01108a1df617defb...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan @roberttoyonaga Pushed as commit e80b76b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.