New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy' #2345
Conversation
…ject disk2 - Resource busy'
|
@sashamatveev The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
All classes from |
…ject disk2 - Resource busy' [v2]
I removed RetryExecutor.java and jdk.jpackage.internal.RetryExecutor will be used instead. |
@sashamatveev This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 233 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
/integrate |
@sashamatveev Since your change was applied there have been 242 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit bec6043. |
We did not able to run "hdiutil convert" due to hdiutil did not able to acquire lock on DMG image file. In this condition we got "Resource busy" from "hdiutil detach" and on repeated attempt we was getting "File Not Found" error. According to some research "Resource Busy" is normal error message for "hdiutil detach" and can happen, but it should go away soon assuming nothing else is broken. I think due to we using "-force" flag we still ejected DMG image and left system in bad stage. After re-fixing repeated detach with force this issue is not longer reproducible. I still left code for forced detach if we did not able to detach it. Also, I added work around (in case we had to do forced detach) is to convert copy of original DMG image. This work around seems to solves problem as well when hdiutil cannot acquire lock on file. I also fixed in same way detach in our test helper.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2345/head:pull/2345
$ git checkout pull/2345