8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings

[fguallini]

When compiling the test class: jdk/test/lib/security/timestamp/TsaServer.java

Two warning are shown:

test/lib/security/timestamp/TsaServer.java:56: warning: [this-escape] possible 'this' escape before subclass is fully initialized
            setHandler(handler);

• setHandler is called in the constructor and a subclass may override it. It is fixed by making the method 'final'

test/lib/security/timestamp/TsaServer.java:42: warning: [try] auto-closeable resource TsaServer has a member method close() that could throw InterruptedException

• Remove throws Exception from TsaServer.close()

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings (Bug - P4)

Reviewers

• Weijun Wang (@wangweij - Reviewer)
• Rajan Halade (@rhalade - Reviewer)
• Hai-May Chao (@haimaychao - Committer)
• Leonid Mesnik (@lmesnik - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23463/head:pull/23463
$ git checkout pull/23463

Update a local copy of the PR:
$ git checkout pull/23463
$ git pull https://git.openjdk.org/jdk.git pull/23463/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23463

View PR using the GUI difftool:
$ git pr show -t 23463

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23463.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346049: jdk/test/lib/security/timestamp/TsaServer.java warnings

Reviewed-by: weijun, rhalade, hchao, lmesnik

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• acb46dd: 8345155: Add /native to native test in FFM
• d85f651: 8349428: RISC-V: "bad alignment" with -XX:-AvoidUnalignedAccesses after JDK-8347489
• 7e30791: 8349102: Test compiler/arguments/TestCodeEntryAlignment.java failed: assert(allocates2(pc)) failed: not in CodeBuffer memory
• 3eb57f6: 8349140: Size optimization (opt-size) build fails after recent PCH changes
• 3cf04de: 8349132: javac Analyzers should handle non-deferrable errors
• 30f7162: 8349417: Fix NULL usage from JDK-8346433
• 64bd8d2: 8349511: [BACKOUT] Framework for tracing makefile inclusion and parsing
• 5e1cc08: 8349504: Support platform-specific JUnit tests in jpackage
• 89e5e7a: 8349155: The "log" parameter to Lint.logIfEnabled() is not needed
• aad6664: 8333569: jpackage tests must run app launchers with retries on Linux only
• ... and 19 more: https://git.openjdk.org/jdk/compare/beb43e2633900bb9ab3c975376fe5860b6d054e0...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@wangweij, @rhalade, @haimaychao, @lmesnik) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@fguallini The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (79275ce3)

[fguallini]

Thanks for reviews 👍

[fguallini]

/integrate

[openjdk]

@fguallini
Your change (at version 79275ce) is now ready to be sponsored by a Committer.

[rhalade]

/sponsor

[openjdk]

Going to push as commit 1eb54e4.
Since your change was applied there have been 44 commits pushed to the master branch:

• a0c7f66: 8349508: runtime/cds/appcds/TestParallelGCWithCDS.java should not check for specific output
• 1079147: 8348570: CTW: Expose the code hidden by uncommon traps
• 1a74ee6: 8349092: File.getFreeSpace violates specification if quotas are in effect (win)
• 0181030: 8349006: File.getCanonicalPath should remove "(on UNIX platforms)" from its specification
• ed8945a: 8347377: Add validation checks for ICC_Profile header fields
• 1ab1c1d: 8349058: 'internal proprietary API' warnings make javac warnings unusable
• eb84702: 8349513: Remove unused BUILD_JDK_JTREG_LIBRARIES_JDK_LIBS_libTracePinnedThreads
• f12d2de: 8345212: Since checker should better handle non numeric values
• 5ec1aae: 8347842: ThreadPoolExecutor specification discusses RuntimePermission
• 3fbae32: 8349465: [UBSAN] test_os_reserve_between.cpp reported applying non-zero offset to null pointer
• ... and 34 more: https://git.openjdk.org/jdk/compare/beb43e2633900bb9ab3c975376fe5860b6d054e0...master

Your commit was automatically rebased without conflicts.

[openjdk]

@rhalade @fguallini Pushed as commit 1eb54e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.