-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8349515: [REDO] Framework for tracing makefile inclusion and parsing #23494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back ihse! A progress list of the required criteria for merging this PR into |
|
@magicus This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 40 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
|
@magicus The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
|
/label -client -compiler -core-libs -hotspot-jfr -i18n -ide-support -kulla -net -serviceability |
|
@magicus The The The The The The The The |
|
/integrate |
|
Going to push as commit 964dd18.
Your commit was automatically rebased without conflicts. |
Re-do of JDK-8348190 Framework for tracing makefile inclusion and parsing.
This should be essentially identical to JDK-8348190; the fixes were in closed Oracle source. My apologizes for all this mess, and that it spilled out in the open JDK instead of being resolved just internally at Oracle. 😿
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23494/head:pull/23494$ git checkout pull/23494Update a local copy of the PR:
$ git checkout pull/23494$ git pull https://git.openjdk.org/jdk.git pull/23494/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23494View PR using the GUI difftool:
$ git pr show -t 23494Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23494.diff
Using Webrev
Link to Webrev Comment