From 5139fc85dbff2d033ea61576e3113d35a9f0f216 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Johan=20Sj=C3=B6l=C3=A9n?= Date: Thu, 6 Feb 2025 20:06:21 +0100 Subject: [PATCH] Don't use address, use void* --- src/hotspot/os/posix/perfMemory_posix.cpp | 2 +- src/hotspot/os/windows/perfMemory_windows.cpp | 2 +- src/hotspot/share/nmt/memTracker.hpp | 4 ++-- src/hotspot/share/runtime/os.cpp | 8 ++++---- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/src/hotspot/os/posix/perfMemory_posix.cpp b/src/hotspot/os/posix/perfMemory_posix.cpp index 72f5311622bb1..4d6fc1e4b8c9e 100644 --- a/src/hotspot/os/posix/perfMemory_posix.cpp +++ b/src/hotspot/os/posix/perfMemory_posix.cpp @@ -1088,7 +1088,7 @@ static void unmap_shared(char* addr, size_t bytes) { MemTracker::NmtVirtualMemoryLocker nvml; res = ::munmap(addr, bytes); if (res == 0) { - MemTracker::record_virtual_memory_release((address)addr, bytes); + MemTracker::record_virtual_memory_release(addr, bytes); } } else { res = ::munmap(addr, bytes); diff --git a/src/hotspot/os/windows/perfMemory_windows.cpp b/src/hotspot/os/windows/perfMemory_windows.cpp index 7a3791ced1a00..dda0acde79346 100644 --- a/src/hotspot/os/windows/perfMemory_windows.cpp +++ b/src/hotspot/os/windows/perfMemory_windows.cpp @@ -1804,7 +1804,7 @@ void PerfMemory::detach(char* addr, size_t bytes) { // it does not go through os api, the operation has to record from here MemTracker::NmtVirtualMemoryLocker nvml; remove_file_mapping(addr); - MemTracker::record_virtual_memory_release((address)addr, bytes); + MemTracker::record_virtual_memory_release(addr, bytes); } else { remove_file_mapping(addr); } diff --git a/src/hotspot/share/nmt/memTracker.hpp b/src/hotspot/share/nmt/memTracker.hpp index 119720448d9ee..70125a1a01929 100644 --- a/src/hotspot/share/nmt/memTracker.hpp +++ b/src/hotspot/share/nmt/memTracker.hpp @@ -135,7 +135,7 @@ class MemTracker : AllStatic { } } - static inline void record_virtual_memory_release(address addr, size_t size) { + static inline void record_virtual_memory_release(void* addr, size_t size) { assert_post_init(); if (!enabled()) return; if (addr != nullptr) { @@ -143,7 +143,7 @@ class MemTracker : AllStatic { } } - static inline void record_virtual_memory_uncommit(address addr, size_t size) { + static inline void record_virtual_memory_uncommit(void* addr, size_t size) { assert_post_init(); if (!enabled()) return; if (addr != nullptr) { diff --git a/src/hotspot/share/runtime/os.cpp b/src/hotspot/share/runtime/os.cpp index 0654bd3e092d8..4bbf4f59231fd 100644 --- a/src/hotspot/share/runtime/os.cpp +++ b/src/hotspot/share/runtime/os.cpp @@ -2204,7 +2204,7 @@ bool os::uncommit_memory(char* addr, size_t bytes, bool executable) { MemTracker::NmtVirtualMemoryLocker nvml; res = pd_uncommit_memory(addr, bytes, executable); if (res) { - MemTracker::record_virtual_memory_uncommit((address)addr, bytes); + MemTracker::record_virtual_memory_uncommit(addr, bytes); } } else { res = pd_uncommit_memory(addr, bytes, executable); @@ -2226,7 +2226,7 @@ bool os::release_memory(char* addr, size_t bytes) { MemTracker::NmtVirtualMemoryLocker nvml; res = pd_release_memory(addr, bytes); if (res) { - MemTracker::record_virtual_memory_release((address)addr, bytes); + MemTracker::record_virtual_memory_release(addr, bytes); } } else { res = pd_release_memory(addr, bytes); @@ -2311,7 +2311,7 @@ bool os::unmap_memory(char *addr, size_t bytes) { MemTracker::NmtVirtualMemoryLocker nvml; result = pd_unmap_memory(addr, bytes); if (result) { - MemTracker::record_virtual_memory_release((address)addr, bytes); + MemTracker::record_virtual_memory_release(addr, bytes); } } else { result = pd_unmap_memory(addr, bytes); @@ -2350,7 +2350,7 @@ bool os::release_memory_special(char* addr, size_t bytes) { MemTracker::NmtVirtualMemoryLocker nvml; res = pd_release_memory_special(addr, bytes); if (res) { - MemTracker::record_virtual_memory_release((address)addr, bytes); + MemTracker::record_virtual_memory_release(addr, bytes); } } else { res = pd_release_memory_special(addr, bytes);