JDK-8260926: Trace resource exhausted events unconditionally

[tstuefe]

Analyzing out-of-resource situations in cloud scenarios is no fun. With CloudFoundry, a JVMTI agent (jvmkill) is hooked up intercepting the jvmti "resource exhausted" event, then attempts to write up a heap report. That may fail, e.g. due to bugs in the agent [1], but also because that report runs java code and may suffer from the same resource exhaustion. Successful or not, it unceremoniously kills the VM when done, often leaving us with no information about the actual resource.

It would be very helpful if we had unconditional tracing here. We do have tracing, but it requires a non-product build and is triggered with TraceJVMTI. Also, it traces at trace level which is way to fine granular.

I'd like to introduce another, unconditional trace line here. Arguably, resource exhausted is fatal enough that it justifies unconditional tracing.

This is a bit of a coin toss. Tracing unconditionally would help in most scenarios, where it would be either difficult or even impossible to specify a trace command line switch. OTOH it may trip up scripts parsing the VM output, or some of our tests (which can be fixed).

Thoughts?

..Thomas

[1] cloudfoundry/jvmkill#18

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260926: Trace resource exhausted events unconditionally

Reviewers

• David Holmes (@dholmes-ora - Reviewer) ⚠️ Review applies to 40e3af8
• Coleen Phillimore (@coleenp - Reviewer) ⚠️ Review applies to 40e3af8

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2350/head:pull/2350
$ git checkout pull/2350

[bridgekeeper]

👋 Welcome back stuefe! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tstuefe The following labels will be automatically applied to this pull request:

• hotspot
• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 02: Full - Incremental (b3d331f)
• 01: Full - Incremental (40e3af8)
• 00: Full (abe2bf6)

[dholmes-ora]

Hi Thomas,

Approval in principle, but changes suggested.

Thanks,
David

[tstuefe]

Hi Thomas,

Approval in principle, but changes suggested.

Thanks,
David

Hi David, thanks for looking at this. I changed text and tag as requested.

..Thomas

[coleenp]

This looks good!

[openjdk]

@tstuefe This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260926: Trace resource exhausted events unconditionally

Reviewed-by: dholmes, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 63 new commits pushed to the master branch:

• 1e0a101: 8259862: MutableSpace's end should be atomic
• d2bd499: 8163498: Many long-running security libs tests
• c5bb109: 8260019: Move some Thread subtypes out of thread.hpp
• 08f7454: 8261190: restore original Alibaba copyright line in two files
• 3bb6a3d: 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4
• c59e4b6: 8261106: Reduce inclusion of jniHandles.hpp
• d9aefa3: 8260356: (tz) Upgrade time-zone data to tzdata2021a
• bdcbfa1: 8259927: Windows jpackage installer issues
• e93e1e1: 8261157: Incorrect GPL header after JDK-8259956
• c1dea39: 8260335: [macos] Running app using relative path causes problems
• ... and 53 more: https://git.openjdk.java.net/jdk/compare/ddd2951ba91fe3860b92d2f9bad4e0d900f1d650...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tstuefe]

Thanks, Coleen!

@dholmes-ora : are you fine with the latest version?

[dholmes-ora]

I would have formatted the message differently as per my first comment. But ok.

[tstuefe]

I would have formatted the message differently as per my first comment. But ok.

Sorry, I misread part your original comment. I changed the message according to your suggestion.

Cheers, Thomas

[tstuefe]

/integrate

[openjdk]

@tstuefe Since your change was applied there have been 63 commits pushed to the master branch:

• 1e0a101: 8259862: MutableSpace's end should be atomic
• d2bd499: 8163498: Many long-running security libs tests
• c5bb109: 8260019: Move some Thread subtypes out of thread.hpp
• 08f7454: 8261190: restore original Alibaba copyright line in two files
• 3bb6a3d: 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4
• c59e4b6: 8261106: Reduce inclusion of jniHandles.hpp
• d9aefa3: 8260356: (tz) Upgrade time-zone data to tzdata2021a
• bdcbfa1: 8259927: Windows jpackage installer issues
• e93e1e1: 8261157: Incorrect GPL header after JDK-8259956
• c1dea39: 8260335: [macos] Running app using relative path causes problems
• ... and 53 more: https://git.openjdk.java.net/jdk/compare/ddd2951ba91fe3860b92d2f9bad4e0d900f1d650...master

Your commit was automatically rebased without conflicts.

Pushed as commit ee2f205.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.