8349579: jsvml.dll incorrect RDATA SEGMENT specification

[missa-prime]

A fix for incorrectly defined program segments in Windows SVML assembly.

• Changes READ to READONLY in all math functions
• Now compliant with MASM x86 and x86_64 program segment specification

The tier1 tests show the changes didn't introduce new failures.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349579: jsvml.dll incorrect RDATA SEGMENT specification (Bug - P4)

Reviewers

• Sandhya Viswanathan (@sviswa7 - Reviewer)
• Jatin Bhateja (@jatin-bhateja - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23503/head:pull/23503
$ git checkout pull/23503

Update a local copy of the PR:
$ git checkout pull/23503
$ git pull https://git.openjdk.org/jdk.git pull/23503/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23503

View PR using the GUI difftool:
$ git pr show -t 23503

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23503.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

Hi @missa-prime, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user missa-prime" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@missa-prime This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349579: jsvml.dll incorrect RDATA SEGMENT specification

Reviewed-by: sviswanathan, jbhateja

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 60 new commits pushed to the master branch:

• ee079fd: 8349820: Temporarily increase MemLimit for tests until JDK-8349772 and JDK-8337821 are fixed
• 545d19f: 8349771: Replace usages of -mx and -ms in some monitor tests
• 5ee44c1: 8349662: SSLTube SSLSubscriptionWrapper has potential races when switching subscriptions
• 964dd18: 8349515: [REDO] Framework for tracing makefile inclusion and parsing
• 8e85829: 8349213: G1: Clearing bitmaps during collection set merging not claimed by region
• 1a8212e: 8348678: [PPC64] C2: unaligned vector load/store is ok
• 41bdc47: 8208377: Soft hyphens render if not using TextLayout
• df654a9: 8349752: Tier1 build failure caused by JDK-8349178
• 527489c: 8349284: Make libExplicitAttach work on static JDK
• f11a737: 8349475: Test tools/javac/api/TestJavacTaskWithWarning.java writes files in src dir
• ... and 50 more: https://git.openjdk.org/jdk/compare/379c3f99665829c5d8c373d1fb324dc7ef4d84cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@sviswa7, @jatin-bhateja) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@missa-prime To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels

• build
• client
• compiler
• core-libs
• graal
• hotspot
• hotspot-compiler
• hotspot-gc
• hotspot-jfr
• hotspot-runtime
• i18n
• ide-support
• javadoc
• jdk
• jmx
• kulla
• net
• nio
• security
• serviceability
• shenandoah

[missa-prime]

/covered

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[missa-prime]

/label hotspot-compiler

[openjdk]

@missa-prime
The hotspot-compiler label was successfully added.

[sviswa7]

Mohamed Issa (github id @missa-prime) is part of Intel Java team and is covered by Intel OCA.

[TheShermanTanker]

Just my 2 cents, this would be more accurately described as jsvml.dll rather than libsvml.so, since this is a Windows only issue

[missa-prime]

Just my 2 cents, this would be more accurately described as jsvml.dll rather than libsvml.so, since this is a Windows only issue

Updated - thanks.

[mlbridge]

Webrevs

• 01: Full - Incremental (f29de5c1)
• 00: Full (6d8e8a5d)

[sviswa7]

Looks good to me.

[openjdk]

⚠️ @missa-prime the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout user/missa-prime/jsvml
$ git commit --author='Preferred Full Name <you@example.com>' --allow-empty -m 'Update full name'
$ git push

[jatin-bhateja]

dumpbin shows no difference in section attributes with and without patch. But, its good to comply with specification.

dumpbin /nologo /SECTION:_RDATA jsvml.dll

40000040 flags
        Initialized Data
        Read Only

[TheShermanTanker]

The microsoft toolchain still creates a literal section named _RDATA even with this change? Guess it's a fault in the toolchain and nothing to do with not conforming to the microsoft docs then. Still, like you said, it's good to follow what microsoft says in their docs

[missa-prime]

/integrate

[openjdk]

@missa-prime
Your change (at version f29de5c) is now ready to be sponsored by a Committer.

[sviswa7]

/sponsor

[openjdk]

Going to push as commit a1bcda2.
Since your change was applied there have been 60 commits pushed to the master branch:

• ee079fd: 8349820: Temporarily increase MemLimit for tests until JDK-8349772 and JDK-8337821 are fixed
• 545d19f: 8349771: Replace usages of -mx and -ms in some monitor tests
• 5ee44c1: 8349662: SSLTube SSLSubscriptionWrapper has potential races when switching subscriptions
• 964dd18: 8349515: [REDO] Framework for tracing makefile inclusion and parsing
• 8e85829: 8349213: G1: Clearing bitmaps during collection set merging not claimed by region
• 1a8212e: 8348678: [PPC64] C2: unaligned vector load/store is ok
• 41bdc47: 8208377: Soft hyphens render if not using TextLayout
• df654a9: 8349752: Tier1 build failure caused by JDK-8349178
• 527489c: 8349284: Make libExplicitAttach work on static JDK
• f11a737: 8349475: Test tools/javac/api/TestJavacTaskWithWarning.java writes files in src dir
• ... and 50 more: https://git.openjdk.org/jdk/compare/379c3f99665829c5d8c373d1fb324dc7ef4d84cf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sviswa7 @missa-prime Pushed as commit a1bcda2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.