8349571: Remove JavaThreadFactory interface from SA

[plummercj]

The SA JavaThreadFactory interface is no longer used, so it is being removed. I stumbled on it while looking at JavaThread related code. It looks like its original purpose is related to JavaThread subclasses at one point being platform dependent, as described in the following JavaThread.java comment:

/** This is an abstract class because there are certain OS- and
    CPU-specific operations (like the setting and getting of the last
    Java frame pointer) which need to be factored out. These
    operations are implemented by, for example,
    SolarisSPARCJavaThread, and the concrete subclasses are
    instantiated by the JavaThreadFactory in the Threads class. */

However, this is no longer the case, and this comment is being removed as part of JDK-8348347.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349571: Remove JavaThreadFactory interface from SA (Enhancement - P5)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)
• Serguei Spitsyn (@sspitsyn - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23505/head:pull/23505
$ git checkout pull/23505

Update a local copy of the PR:
$ git checkout pull/23505
$ git pull https://git.openjdk.org/jdk.git pull/23505/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23505

View PR using the GUI difftool:
$ git pr show -t 23505

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23505.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349571: Remove JavaThreadFactory interface from SA

Reviewed-by: kevinw, sspitsyn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 178 new commits pushed to the master branch:

• ba28119: 8348427: DeferredLintHandler API should use JCTree instead of DiagnosticPosition
• c5ac3c4: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore
• 336d0d8: 8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c
• 4b463ee: 8342103: C2 compiler support for Float16 type and associated scalar operations
• 332d87c: 8349859: Support static JDK in libfontmanager/freetypeScaler.c
• 73e1780: 8349836: G1: Improve group prediction log message
• ed17c55: 8349145: Make Class.getProtectionDomain() non-native
• e700460: 8349813: Test behavior of limiting() on RS operators throwing exceptions
• 08f4c1c: 8349781: make test TEST=gtest fails on WSL
• bb41df4: 8349723: Problemlist jdp tests for macosx-x64
• ... and 168 more: https://git.openjdk.org/jdk/compare/81032560f797dc18bd6a4a75b44c26925aabac5b...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (282aa05f)

[kevinjwalls]

Looks good, I see no other references.

[sspitsyn]

Looks good.

[plummercj]

Thank you for the reviews Kevin and Serguei!

/integrate

[openjdk]

Going to push as commit 2a5d1da.
Since your change was applied there have been 179 commits pushed to the master branch:

• 74e458b: 8349684: Remove SA core file tests from problem list for macosx-x64
• ba28119: 8348427: DeferredLintHandler API should use JCTree instead of DiagnosticPosition
• c5ac3c4: 8249831: Test sun/security/mscapi/nonUniqueAliases/NonUniqueAliases.java is marked with @ignore
• 336d0d8: 8349926: [BACKOUT] Support static JDK in libfontmanager/freetypeScaler.c
• 4b463ee: 8342103: C2 compiler support for Float16 type and associated scalar operations
• 332d87c: 8349859: Support static JDK in libfontmanager/freetypeScaler.c
• 73e1780: 8349836: G1: Improve group prediction log message
• ed17c55: 8349145: Make Class.getProtectionDomain() non-native
• e700460: 8349813: Test behavior of limiting() on RS operators throwing exceptions
• 08f4c1c: 8349781: make test TEST=gtest fails on WSL
• ... and 169 more: https://git.openjdk.org/jdk/compare/81032560f797dc18bd6a4a75b44c26925aabac5b...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 2a5d1da.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.