8260928: InitArrayShortSize constraint func should print a helpful error message

[TobiHartmann]

The InitArrayShortSize flag requires a value that is a multiple of BytesPerLong but no corresponding error message is printed:

java -XX:InitArrayShortSize=7
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Thanks,
Tobias

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8260928: InitArrayShortSize constraint func should print a helpful error message

Reviewers

• Aleksey Shipilev (@shipilev - Reviewer) ⚠️ Review applies to 92dd131
• Christian Hagedorn (@chhagedorn - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2351/head:pull/2351
$ git checkout pull/2351

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[TobiHartmann]

/label remove hotspot-runtime
/label add hotspot-compiler

[openjdk]

@TobiHartmann
The hotspot-runtime label was successfully removed.

[openjdk]

@TobiHartmann
The hotspot-compiler label was successfully added.

[mlbridge]

Webrevs

• 01: Full - Incremental (bb87bdd)
• 00: Full (92dd131)

[shipilev]

Looks fine to me.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8260928: InitArrayShortSize constraint func should print a helpful error message

Reviewed-by: shade, chagedorn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 189b65b: 8260264: Move common os_ inline methods to a common posix source file

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Consider indenting them a bit. I think the line starting from "a... has one excess whitespace.

[TobiHartmann]

Good catch. Fixed. Thanks for the review!

[chhagedorn]

Looks good.

[TobiHartmann]

Thanks for the review, Christian!

[TobiHartmann]

/integrate

[openjdk]

@TobiHartmann Since your change was applied there have been 18 commits pushed to the master branch:

• cb127a4: 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o printer
• c008410: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
• b9d4211: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX
• 98a7692: 8076313: GraphicsEnvironment does not detect changes in count of monitors on Linux OS
• a47befc: 8260878: com/sun/jdi/JdbOptions.java fails without jfr
• d423d36: 8258508: Merge G1RedirtyCardsQueue into qset
• bec6043: 8259570: (macos) tools/jpackage tests fails with 'hdiutil: couldn't eject "disk2" - Resource busy'
• ffbcf1b: 8260471: Change SystemDictionary::X_klass calls to vmClasses::X_klass
• 9af3339: 8261003: Bad Copyright header format after JDK-8183372
• 6dc3c6d: 8183372: Refactor java/lang/Class shell tests to java
• ... and 8 more: https://git.openjdk.java.net/jdk/compare/288a4fed3f495e5bb83839564eda7d0c78751d21...master

Your commit was automatically rebased without conflicts.

Pushed as commit 91e6c75.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.