8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails

[sendaoYan]

Hi all,

The glibc function mallinfo() do do not work with -fsanitize=adddress, maybe it's limitation or bug of address sanitizer . Should we disable the gtest 'os_linux.glibc_mallinfo_wrapper_vm' when configure and build with address sanitizer. The macro ADDRESS_SANITIZER will always pass to gcc/clang/microsoft compiler when enable address sanitizer. So this PR check the macro ADDRESS_SANITIZER to enable the test or not.

On the other hand, this test get malloc usage information by call os::Linux::get_mallinfo and check "total allocation values" greater than 2K before allocate the memort by malloc(2K). Call os::Linux::get_mallinfo should after malloc(2K).

Below code snippet can demonstrate the glibc function mallinfo() do do not work with -fsanitize=adddress.

#include <stdio.h>
#include <malloc.h>

int main() {
    struct mallinfo info;
    info = mallinfo();

    printf("%d, %d, %d, %d, %d, %d, %d, %d, %d, %d\n", info.arena, info.ordblks, info.smblks, info.hblks, info.hblkhd, info.usmblks, info.fsmblks, info.uordblks, info.fordblks, info.keepcost);

    char* ptr = malloc(0x10000);
    info = mallinfo();

    printf("%d, %d, %d, %d, %d, %d, %d, %d, %d, %d\n", info.arena, info.ordblks, info.smblks, info.hblks, info.hblkhd, info.usmblks, info.fsmblks, info.uordblks, info.fordblks, info.keepcost);

    free(ptr);
    return 0;
}

• Without -fsanitize=address, mallinfo() works normally.

gcc mallinfo.c && ./a.out
0, 1, 0, 0, 0, 0, 0, 0, 0, 0
135168, 1, 0, 0, 0, 0, 0, 67248, 67920, 67920

• With -fsanitize=address, mallinfo() works abnormally.

gcc -fsanitize=address mallinfo.c && ./a.out
0, 0, 0, 0, 0, 0, 0, 0, 0, 0
0, 0, 0, 0, 0, 0, 0, 0, 0, 0

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails (Bug - P4)

Reviewers

• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23510/head:pull/23510
$ git checkout pull/23510

Update a local copy of the PR:
$ git checkout pull/23510
$ git pull https://git.openjdk.org/jdk.git pull/23510/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23510

View PR using the GUI difftool:
$ git pr show -t 23510

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23510.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349623: [ASAN] Gtest os_linux.glibc_mallinfo_wrapper_vm fails

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 323 new commits pushed to the master branch:

• 7314efc: 8351377: Fix the ProblemList for com/sun/management/OperatingSystemMXBean cpuLoad tests on AIX
• 7c9a784: 8351223: Update localized resources in keytool and jarsigner
• a23fb0a: 8348110: Update LCMS to 2.17
• 0892913: 8351086: (fc) Make java/nio/channels/FileChannel/BlockDeviceSize.java test manual
• 93f2260: 8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File}
• 8f8a879: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean
• cfab88b: 8351256: Improve printing of runtime call stub names in disassember output
• 7a5acb9: 8343840: Rewrite the ObjectMonitor lists
• 40f150d: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
• 649ef77: 8323158: HotSpot Style Guide should specify more include ordering
• ... and 313 more: https://git.openjdk.org/jdk/compare/3989a199578fc1d91988cfdbb95f11dd6d4c7b81...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@sendaoYan The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (748cae2a)

[bridgekeeper]

@sendaoYan This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[sendaoYan]

keep it open.

[sendaoYan]

@tstuefe Hi, could you take look this PR.

[tstuefe]

Good

[sendaoYan]

Thanks @tstuefe

/integrate

[openjdk]

Going to push as commit 155697f.
Since your change was applied there have been 324 commits pushed to the master branch:

• 4066f33: 8350565: NMT: remaining memory flag/type to be replaced with memory tag
• 7314efc: 8351377: Fix the ProblemList for com/sun/management/OperatingSystemMXBean cpuLoad tests on AIX
• 7c9a784: 8351223: Update localized resources in keytool and jarsigner
• a23fb0a: 8348110: Update LCMS to 2.17
• 0892913: 8351086: (fc) Make java/nio/channels/FileChannel/BlockDeviceSize.java test manual
• 93f2260: 8351294: (fs) Minor verbiage correction for Files.createTemp{Directory,File}
• 8f8a879: 8350939: Revisit Windows PDH buffer size calculation for OperatingSystemMXBean
• cfab88b: 8351256: Improve printing of runtime call stub names in disassember output
• 7a5acb9: 8343840: Rewrite the ObjectMonitor lists
• 40f150d: 8330936: [ubsan] exclude function BilinearInterp and ShapeSINextSpan in libawt java2d from ubsan checks
• ... and 314 more: https://git.openjdk.org/jdk/compare/3989a199578fc1d91988cfdbb95f11dd6d4c7b81...master

Your commit was automatically rebased without conflicts.

[openjdk]

@sendaoYan Pushed as commit 155697f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.