Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8235140: Investigate deprecation of the Socket/ServerSocket impl factory mechanism #2352

Closed
wants to merge 2 commits into from

Conversation

pconcannon
Copy link
Contributor

@pconcannon pconcannon commented Feb 2, 2021

Hi,

Could someone please review my proposed change for JDK-8235140: 'Investigate deprecation of the Socket/ServerSocket impl factory mechanism' ?

This fix proposes to deprecate (for the eventual removal) the API points for statically configuring a system-wide factory for the Socket/SocketServer types in the java.net package. Specifically, the following:

Methods:

  • static void ServerSocket.setSocketFactory​(SocketImplFactory fac)
  • static void Socket.setSocketImplFactory​(SocketImplFactory fac)

Types:

  • java.net SocketImplFactory

This issue is a sub-task to the umbrella issue JDK-8235139: 'Remove the socket impl factory mechanism'. For more information, see https://bugs.openjdk.java.net/browse/JDK-8235139

Kind regards,
Patrick


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8235140: Investigate deprecation of the Socket/ServerSocket impl factory mechanism

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2352/head:pull/2352
$ git checkout pull/2352

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2021

👋 Welcome back pconcannon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@pconcannon The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Feb 2, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 2, 2021

Webrevs

@pconcannon pconcannon changed the title 8235140: 'Investigate deprecation of the Socket/ServerSocket impl factory mechanism' 8235140: Investigate deprecation of the Socket/ServerSocket impl factory mechanism Feb 2, 2021
@pconcannon pconcannon closed this Feb 2, 2021
@pconcannon pconcannon deleted the JDK-8235140 branch February 11, 2021 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
net net-dev@openjdk.org rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

1 participant