Skip to content

8327378: XMLStreamReader throws EOFException instead of XMLStreamException#23524

Closed
JoeWang-Java wants to merge 1 commit intoopenjdk:masterfrom
JoeWang-Java:JDK-8327378
Closed

8327378: XMLStreamReader throws EOFException instead of XMLStreamException#23524
JoeWang-Java wants to merge 1 commit intoopenjdk:masterfrom
JoeWang-Java:JDK-8327378

Conversation

@JoeWang-Java
Copy link
Member

@JoeWang-Java JoeWang-Java commented Feb 7, 2025

Fix an error handling where the XMLStreamReader impl throws EOFException instead of XMLStreamException as defined.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8327378: XMLStreamReader throws EOFException instead of XMLStreamException (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23524/head:pull/23524
$ git checkout pull/23524

Update a local copy of the PR:
$ git checkout pull/23524
$ git pull https://git.openjdk.org/jdk.git pull/23524/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23524

View PR using the GUI difftool:
$ git pr show -t 23524

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23524.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2025

👋 Welcome back joehw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 7, 2025

@JoeWang-Java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8327378: XMLStreamReader throws EOFException instead of XMLStreamException

Reviewed-by: iris, lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • f0ea38b: 8349509: [macos] Clean up macOS dead code in jpackage
  • 7f6c687: 8349374: [JVMCI] concurrent use of HotSpotSpeculationLog can crash
  • bd9b24c: 8349512: Duplicate PermittedSubclasses entries with doclint enabled

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 7, 2025
@openjdk
Copy link

openjdk bot commented Feb 7, 2025

@JoeWang-Java The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Feb 7, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2025

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 7, 2025
Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK Joe

I might suggest an RN to give a heads up on the change of Exception to match he spec

Copy link
Member

@naotoj naotoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JoeWang-Java
Copy link
Member Author

RN added. Thanks all!

@JoeWang-Java
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Feb 8, 2025

Going to push as commit 5395ffa.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 1ed9ef1: 8349559: Compiler interface doesn't need to store protection domain
  • f0ea38b: 8349509: [macos] Clean up macOS dead code in jpackage
  • 7f6c687: 8349374: [JVMCI] concurrent use of HotSpotSpeculationLog can crash
  • bd9b24c: 8349512: Duplicate PermittedSubclasses entries with doclint enabled

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 8, 2025
@openjdk openjdk bot closed this Feb 8, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 8, 2025
@openjdk
Copy link

openjdk bot commented Feb 8, 2025

@JoeWang-Java Pushed as commit 5395ffa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@JoeWang-Java JoeWang-Java deleted the JDK-8327378 branch February 8, 2025 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

4 participants

Comments