Skip to content

Conversation

@lmesnik
Copy link
Member

@lmesnik lmesnik commented Feb 7, 2025

The fix add remaining classes to the testlibrary jar and fix some warnings in security-related classes.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346050: Update BuildTestLib.gmk to build whole testlibrary (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23525/head:pull/23525
$ git checkout pull/23525

Update a local copy of the PR:
$ git checkout pull/23525
$ git pull https://git.openjdk.org/jdk.git pull/23525/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23525

View PR using the GUI difftool:
$ git pr show -t 23525

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23525.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 7, 2025

👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 7, 2025

@lmesnik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346050: Update BuildTestLib.gmk to build whole testlibrary

Reviewed-by: weijun, ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 104 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 7, 2025
@openjdk
Copy link

openjdk bot commented Feb 7, 2025

@lmesnik The following labels will be automatically applied to this pull request:

  • build
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org labels Feb 7, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 7, 2025

Webrevs

Co-authored-by: Erik Joelsson <37597443+erikj79@users.noreply.github.com>
@openjdk
Copy link

openjdk bot commented Feb 11, 2025

⚠️ @lmesnik This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

Copy link
Member

@magicus magicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 12, 2025
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Feb 14, 2025
@lmesnik
Copy link
Member Author

lmesnik commented Feb 18, 2025

/inteagrate

@openjdk
Copy link

openjdk bot commented Feb 18, 2025

@lmesnik Unknown command inteagrate - for a list of valid commands use /help.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 18, 2025
@lmesnik
Copy link
Member Author

lmesnik commented Feb 18, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Feb 18, 2025

@lmesnik An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation.

@lmesnik
Copy link
Member Author

lmesnik commented Feb 18, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Feb 18, 2025

Going to push as commit 62d93f2.
Since your change was applied there have been 104 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 18, 2025
@openjdk openjdk bot closed this Feb 18, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 18, 2025
@openjdk
Copy link

openjdk bot commented Feb 18, 2025

@lmesnik Pushed as commit 62d93f2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build build-dev@openjdk.org integrated Pull request has been integrated security security-dev@openjdk.org

Development

Successfully merging this pull request may close these issues.

4 participants