-
Notifications
You must be signed in to change notification settings - Fork 6.2k
8346050: Update BuildTestLib.gmk to build whole testlibrary #23525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back lmesnik! A progress list of the required criteria for merging this PR into |
|
@lmesnik This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 104 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
Co-authored-by: Erik Joelsson <37597443+erikj79@users.noreply.github.com>
|
|
magicus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM now
|
/inteagrate |
|
@lmesnik Unknown command |
|
/integrate |
|
@lmesnik An unexpected error occurred during integration. No push attempt will be made. The error has been logged and will be investigated. It is possible that this error is caused by a transient issue; feel free to retry the operation. |
|
/integrate |
|
Going to push as commit 62d93f2.
Your commit was automatically rebased without conflicts. |
The fix add remaining classes to the testlibrary jar and fix some warnings in security-related classes.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23525/head:pull/23525$ git checkout pull/23525Update a local copy of the PR:
$ git checkout pull/23525$ git pull https://git.openjdk.org/jdk.git pull/23525/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 23525View PR using the GUI difftool:
$ git pr show -t 23525Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23525.diff
Using Webrev
Link to Webrev Comment