Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259430: C2: assert(in_vt->length() == out_vt->length()) failed: mismatch on number of elements #2353

Closed
wants to merge 1 commit into from

Conversation

iwanowww
Copy link

@iwanowww iwanowww commented Feb 2, 2021

Another problem caused by pathological cases (in effectively dead code): VectorUnboxNode::Ideal()/Value() ignore cast nodes (even the ones carrying control dependency) to reveal VectorBox and sometimes it exposes type mismatches between box/unbox operations which are impossible in practice.

Proposed fix turns the assert into a runtime check to ignore problematic IR shape.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259430: C2: assert(in_vt->length() == out_vt->length()) failed: mismatch on number of elements

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2353/head:pull/2353
$ git checkout pull/2353

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2021

👋 Welcome back vlivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@iwanowww The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Feb 2, 2021
@iwanowww iwanowww marked this pull request as ready for review Feb 5, 2021
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 5, 2021
@mlbridge
Copy link

mlbridge bot commented Feb 5, 2021

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Good.

@openjdk
Copy link

openjdk bot commented Feb 5, 2021

@iwanowww This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259430: C2: assert(in_vt->length() == out_vt->length()) failed: mismatch on number of elements

Reviewed-by: kvn, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 136 new commits pushed to the master branch:

  • 837bd89: 8261548: ProblemList runtime/NMT/CheckForProperDetailStackTrace.java
  • adca84c: 8260341: CDS dump VM init code does not check exceptions
  • 447db62: 6211198: ICC_Profile.getInstance(byte[]): IAE is not specified
  • cc5691c: 8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed
  • 40754f1: 4841153: java.awt.geom.Rectangle2D.add(double,double) documented incorrectly
  • 4caeb39: 8260380: Upgrade to LittleCMS 2.12
  • a772639: 8261298: LinuxPackage.c, getJvmLauncherLibPath RPM->DEB typo
  • 52fc01b: 8261268: LOAD_INSTANCE placeholders unneeded for parallelCapable class loaders
  • a3d6e37: 8261302: NMT: Improve malloc site table hashing
  • ad54d8d: 8260934: java/lang/StringBuilder/HugeCapacity.java fails without Compact Strings
  • ... and 126 more: https://git.openjdk.java.net/jdk/compare/288a4fed3f495e5bb83839564eda7d0c78751d21...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 5, 2021
Copy link
Member

@TobiHartmann TobiHartmann left a comment

Looks reasonable to me.

@iwanowww
Copy link
Author

iwanowww commented Feb 11, 2021

Thanks for the reviews, Vladimir and Tobias.

@iwanowww
Copy link
Author

iwanowww commented Feb 11, 2021

/integrate

@openjdk openjdk bot closed this Feb 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 11, 2021
@openjdk
Copy link

openjdk bot commented Feb 11, 2021

@iwanowww Since your change was applied there have been 138 commits pushed to the master branch:

  • 1662373: 8235139: Deprecate the socket impl factory mechanism
  • 49cf13d: 8261449: Micro-optimize JVM_LatestUserDefinedLoader
  • 837bd89: 8261548: ProblemList runtime/NMT/CheckForProperDetailStackTrace.java
  • adca84c: 8260341: CDS dump VM init code does not check exceptions
  • 447db62: 6211198: ICC_Profile.getInstance(byte[]): IAE is not specified
  • cc5691c: 8248162: serviceability/attach/RemovingUnixDomainSocketTest.java failed
  • 40754f1: 4841153: java.awt.geom.Rectangle2D.add(double,double) documented incorrectly
  • 4caeb39: 8260380: Upgrade to LittleCMS 2.12
  • a772639: 8261298: LinuxPackage.c, getJvmLauncherLibPath RPM->DEB typo
  • 52fc01b: 8261268: LOAD_INSTANCE placeholders unneeded for parallelCapable class loaders
  • ... and 128 more: https://git.openjdk.java.net/jdk/compare/288a4fed3f495e5bb83839564eda7d0c78751d21...master

Your commit was automatically rebased without conflicts.

Pushed as commit 3ede231.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
3 participants