-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8339280: jarsigner -verify performs cross-checking between CEN and LOC #23532
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
43 commits
Select commit
Hold shift + click to select a range
8b813c2
8339280: jarsigner -verify performs cross-checking between CEN and LOC
haimaychao 29b28a6
Revert changes to PushbackInputStream.java
haimaychao aa39c3d
Revert changes to JavaUtilZipFileAccess.java
haimaychao 965fc70
Add TrackPushbackInputStream to extend PushbackInputStream
haimaychao e5e4ad5
Add TrackPushbackInputStream to extend PushbackInputStream
haimaychao 8af1659
Revert changes to SharedSecrets.java
haimaychao ae33d07
Remove shared secret access JavaPBInputStreamAccess.java
haimaychao f67010e
Move JarsignerVerify.java to closed repo
haimaychao 156c147
Revert changes to ZipEntry.java
haimaychao 2fe64e0
Revert changes to ZipFile.java
haimaychao f0d2b35
Revert changes to ZipInputStream.java
haimaychao 6299839
Revert changes to JavaUtilZipFileAccess.java
haimaychao 84c8acb
Remove subclass TrackPushbackInputStream.java
haimaychao 41dd7f3
Revert changes to PreserveRawManifestEntryAndDigest.java
haimaychao cc73b09
Revert changes to LowerCaseManifest.java
haimaychao 130b3e2
Revert changes to Test.java
haimaychao 50599b7
Revert changes to Main.java
haimaychao 87817bc
Revert changes to Resources.java
haimaychao 7fe6a73
Add cross checking in jarsigner instead of accessing ZIP internals
haimaychao d5fe503
Test on large entry
haimaychao eef4f11
Remove unneeded compressed large jar test
haimaychao 28a9038
Update with review comment
haimaychao d7f8536
Revert changes
haimaychao daed840
Merge
haimaychao ad61b35
changes merged
haimaychao 867ba60
Remove sorting for cenEntries
haimaychao 31dcf68
Remove only if 1st entry is MANIFEST in cenEntries
haimaychao 5d93e4d
Add testcase for entry name integrity check
haimaychao ef546f4
Update readEntry() and accumulate more warnings in compareManifest()
haimaychao 219e91a
Update warnings to be more user-friendly (not with CEN/LOC)
haimaychao 0d53bef
Convert new test to junit
haimaychao 15544e2
Update test to include validating the un-modified jar
haimaychao 56bd8b7
Update test with comment and formatting
haimaychao e70597d
Update test with more ZipEntry in the jar
haimaychao 2ef9e5c
Updated with Sean's comments
haimaychao a963de7
Update with comments from Sean and Weijun
haimaychao 286f8b1
Update warning messages
haimaychao 18da4b0
Not split warning in rb.getString() accross multi-lines for Usages.java
haimaychao 9736f59
Remove fast failing upon manifest issue and entry order check
haimaychao 8ec7784
Add CEN/LOC summary warning to Informational Warnings
haimaychao da29c5e
Remove extra line break
haimaychao 4c801be
Fix typo
haimaychao 78093d4
Update with Weijun's comments
haimaychao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update readEntry() and accumulate more warnings in compareManifest()
- Loading branch information
commit ef546f4b778e8a1f43dbedc56a79bb53d169a1e7
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can be rewritten as
is.transferTo(OutputStream.nullOutputStream()).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.