8234534: Simplify CardTable code after CMS removal

[tschatzl]

Hi,

can I have reviews for this cleanup that removes CMS specific code from CardTable/CardTableRS?

Note that there is still this "conc_scan" parameter passed to the card table that affects barrier code generation, for some reason also G1 barrier code generation although it should not as G1CardTable::scanned_concurrently() only used for the "normal" card table. Initial attempts showed that removing this is not straightforward, causing crashes and so I left it out for JDK-8250941 so that this change is solely about removing unused code.

Testing: tier1-4, some tier1-5 runs earlier (before some removal of hunks for files only containing copyright updates or newline changes)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8234534: Simplify CardTable code after CMS removal

Reviewers

• Albert Mingkun Yang (@albertnetymk - Author) ⚠️ Review applies to 5aa23d7
• Kim Barrett (@kimbarrett - Reviewer) ⚠️ Review applies to 5aa23d7

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2354/head:pull/2354
$ git checkout pull/2354

[bridgekeeper]

👋 Welcome back tschatzl! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@tschatzl The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[tschatzl]

/label add hotspot-gc

[openjdk]

@tschatzl
The hotspot-gc label was successfully added.

[tschatzl]

(latest tier1-4 testing still stuck on linux-aarch64, but everything else passed. I think there is no particular aarch64 specific change in there...)

[mlbridge]

Webrevs

• 01: Full - Incremental (849c79b)
• 00: Full (5aa23d7)

[kimbarrett]

Looks good to me, with the one minor nit I commented on and Albert's suggestions.

[openjdk]

@tschatzl This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8234534: Simplify CardTable code after CMS removal

Reviewed-by: ayang, kbarrett

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• be772ff: 8261023: Document why memory pretouch must be a store
• 83357b1: 8261030: Avoid loading GenerateJLIClassesHelper at runtime
• 992b500: 8261036: Reduce classes loaded by CleanerFactory initialization
• e8ad8b3: 8259956: jdk.jfr.internal.ChunkInputStream#available should return the sum of remaining available bytes
• 06b33a0: 8261107: ArrayIndexOutOfBoundsException in the ICC_Profile.getInstance(InputStream)
• 60f440d: 6436374: Graphics.setColor(null) is not documented
• 82028e7: 8260012: Reduce inclusion of collectedHeap.hpp and heapInspection.hpp
• 9b7a8f1: Merge
• 1a7040e: 8259794: Remove EA from JDK 16 version string starting with Initial RC promotion on Feb 04, 2021(B35)
• afd5eef: 8260704: ParallelGC: oldgen expansion needs release-store for _end
• ... and 41 more: https://git.openjdk.java.net/jdk/compare/288a4fed3f495e5bb83839564eda7d0c78751d21...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[tschatzl]

All fixed as suggested. Still compiles.

[tschatzl]

Thanks @kimbarrett @albertnetymk for your reviews.

/integrate

[openjdk]

@tschatzl Since your change was applied there have been 63 commits pushed to the master branch:

• ee2f205: 8260926: Trace resource exhausted events unconditionally
• 1e0a101: 8259862: MutableSpace's end should be atomic
• d2bd499: 8163498: Many long-running security libs tests
• c5bb109: 8260019: Move some Thread subtypes out of thread.hpp
• 08f7454: 8261190: restore original Alibaba copyright line in two files
• 3bb6a3d: 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4
• c59e4b6: 8261106: Reduce inclusion of jniHandles.hpp
• d9aefa3: 8260356: (tz) Upgrade time-zone data to tzdata2021a
• bdcbfa1: 8259927: Windows jpackage installer issues
• e93e1e1: 8261157: Incorrect GPL header after JDK-8259956
• ... and 53 more: https://git.openjdk.java.net/jdk/compare/288a4fed3f495e5bb83839564eda7d0c78751d21...master

Your commit was automatically rebased without conflicts.

Pushed as commit 78b0d32.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.