Skip to content

JDK-8349780 : AIX os::get_summary_cpu_info support Power 11#23556

Closed
suchismith1993 wants to merge 5 commits intoopenjdk:masterfrom
suchismith1993:P11Check
Closed

JDK-8349780 : AIX os::get_summary_cpu_info support Power 11#23556
suchismith1993 wants to merge 5 commits intoopenjdk:masterfrom
suchismith1993:P11Check

Conversation

@suchismith1993
Copy link
Contributor

@suchismith1993 suchismith1993 commented Feb 11, 2025

AIX os::get_summary_cpu_info function still misses support for Power 11, this should be changed.

JBS-Issue: JDK-8349780


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8349780: AIX os::get_summary_cpu_info support Power 11 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/23556/head:pull/23556
$ git checkout pull/23556

Update a local copy of the PR:
$ git checkout pull/23556
$ git pull https://git.openjdk.org/jdk.git pull/23556/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 23556

View PR using the GUI difftool:
$ git pr show -t 23556

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/23556.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 11, 2025

👋 Welcome back sroy! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Feb 11, 2025

@suchismith1993 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8349780: AIX os::get_summary_cpu_info  support Power 11

Reviewed-by: stuefe, amitkumar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • 650d0d9: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable
  • 906358d: 8294155: Exception thrown before awaitAndCheck hangs PassFailJFrame
  • 2bd8f02: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
  • 7f3ecb4: 8346664: C2: Optimize mask check with constant offset
  • b3a4026: 8349764: RISC-V: C1: Improve Class.isInstance intrinsic
  • 071c8f5: 8349909: jdk.internal.jimage.decompressor.ZipDecompressor does not close the Inflater in exceptional cases
  • f1258f9: 8349755: Fix corner case issues in async UL
  • b1b4828: 8350086: Inline hot Method accessors for faster task selection
  • 5e9d72e: 8350094: Linux gcc 13.2.0 build fails when ubsan is enabled
  • 2192723: 8350162: ProblemList compiler/tiered/Level2RecompilationTest.java
  • ... and 86 more: https://git.openjdk.org/jdk/compare/86cec4ea2c2c56f03b23be44caade49b922cd3c6...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@tstuefe, @offamitkumar) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Feb 11, 2025

@suchismith1993 The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Feb 11, 2025
@suchismith1993 suchismith1993 marked this pull request as ready for review February 15, 2025 15:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 15, 2025
@mlbridge
Copy link

mlbridge bot commented Feb 15, 2025

Webrevs

@suchismith1993
Copy link
Contributor Author

suchismith1993 commented Feb 15, 2025

Test run
bash-5.2# java -XX:ErrorHandlerTest=1

#
# A fatal error has been detected by the Java Runtime Environment:
#
# Internal Error (/home/hotspot/openjdk/suchijdk17/jdk/src/hotspot/share/utilities/vmError.cpp:2090), pid=8978868, tid=258
# assert(how == 0) failed: test assert
#
# JRE version: OpenJDK Runtime Environment (25.0) (fastdebug build 25-internal-adhoc.hotspot.jdk)
# Java VM: OpenJDK 64-Bit Server VM (fastdebug 25-internal-adhoc.hotspot.jdk, mixed mode, tiered, compressed oops, compressed class ptrs, g1 gc, aix-ppc64)
# Core dump will be written. Default location: /home/suchismith/jdk/bin/core or core.8978868 (max size 1048575 k). To ensure a full core dump, try "ulimit -c unlimited" before starting Java again
#
# An error report file with more information is saved as:
# /home/suchismith/jdk/bin/hs_err_pid8978868.log
PV_11_Compat
#
# If you would like to submit a bug report, please visit:
# https://bugreport.java.com/bugreport/crash.jsp
#
IOT/Abort trap (core dumped)

'

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2025
@suchismith1993
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Feb 17, 2025
@openjdk
Copy link

openjdk bot commented Feb 17, 2025

@suchismith1993
Your change (at version 2590810) is now ready to be sponsored by a Committer.

@offamitkumar
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Feb 17, 2025

Going to push as commit 8b2aa51.
Since your change was applied there have been 96 commits pushed to the master branch:

  • 650d0d9: 8348865: JButton/bug4796987.java never runs because Windows XP is unavailable
  • 906358d: 8294155: Exception thrown before awaitAndCheck hangs PassFailJFrame
  • 2bd8f02: 8342524: Use latch in AbstractButton/bug6298940.java instead of delay
  • 7f3ecb4: 8346664: C2: Optimize mask check with constant offset
  • b3a4026: 8349764: RISC-V: C1: Improve Class.isInstance intrinsic
  • 071c8f5: 8349909: jdk.internal.jimage.decompressor.ZipDecompressor does not close the Inflater in exceptional cases
  • f1258f9: 8349755: Fix corner case issues in async UL
  • b1b4828: 8350086: Inline hot Method accessors for faster task selection
  • 5e9d72e: 8350094: Linux gcc 13.2.0 build fails when ubsan is enabled
  • 2192723: 8350162: ProblemList compiler/tiered/Level2RecompilationTest.java
  • ... and 86 more: https://git.openjdk.org/jdk/compare/86cec4ea2c2c56f03b23be44caade49b922cd3c6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 17, 2025
@openjdk openjdk bot closed this Feb 17, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Feb 17, 2025
@openjdk
Copy link

openjdk bot commented Feb 17, 2025

@offamitkumar @suchismith1993 Pushed as commit 8b2aa51.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants