Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDK-8241995: Clarify InetSocketAddress::toString specification #2357

Closed
wants to merge 2 commits into from

Conversation

FrauBoes
Copy link
Member

@FrauBoes FrauBoes commented Feb 2, 2021

This change clarifies the InetSocketAddress::toString specification, which was recently updated to reflect an implementation change [1]. The specification is not changed, but it is enhanced with two examples and some more verbiage, as per earlier suggestions on the net-dev mailing list [2][3].

[1] https://bugs.openjdk.java.net/browse/JDK-8225499
[2] https://mail.openjdk.java.net/pipermail/net-dev/2020-April/013776.html
[3] https://mail.openjdk.java.net/pipermail/net-dev/2021-February/015297.html


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8241995: Clarify InetSocketAddress::toString specification

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2357/head:pull/2357
$ git checkout pull/2357

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 2, 2021

👋 Welcome back jboes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Feb 2, 2021
@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@FrauBoes The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Feb 2, 2021
@FrauBoes
Copy link
Member Author

FrauBoes commented Feb 2, 2021

/csr unneeded

@openjdk
Copy link

openjdk bot commented Feb 2, 2021

@FrauBoes only Reviewers can determine that a CSR is not needed.

@mlbridge
Copy link

mlbridge bot commented Feb 2, 2021

Webrevs

Copy link
Member

@Michael-Mc-Mahon Michael-Mc-Mahon left a comment

Maybe could say "rather than parsing the output of toString()" instead of "rather than parsing the string representation". Might be clearer?

@FrauBoes
Copy link
Member Author

FrauBoes commented Feb 3, 2021

Ok, how about this: "rather than parsing the string returned by this toString() method"?

@jaikiran
Copy link
Member

jaikiran commented Feb 3, 2021

Thank you for this change. This PR looks fine to me and your latest suggestion about rewording that last paragraph sounds good too.

@openjdk
Copy link

openjdk bot commented Feb 3, 2021

@FrauBoes This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8241995: Clarify InetSocketAddress::toString specification

Reviewed-by: michaelm, chegar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 21 new commits pushed to the master branch:

  • 0ef93fe: 8259265: Refactor UncaughtExceptions shell test as java test.
  • 5324b5c: 8260998: Shenandoah: Restore reference processing statistics reporting
  • c8de943: 8260617: Merge ZipFile encoding check with the initial hash calculation
  • ae2c5f0: 8260581: IGV: enhance node search
  • 9037615: 8222850: jshell tool: Misleading cascade compiler error in switch expression with undefined vars
  • 91e6c75: 8260928: InitArrayShortSize constraint func should print a helpful error message
  • cb127a4: 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o printer
  • c008410: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
  • b9d4211: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX
  • 98a7692: 8076313: GraphicsEnvironment does not detect changes in count of monitors on Linux OS
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/defcb042707b344ff892b78c7360f1c8478e408f...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 3, 2021
@FrauBoes
Copy link
Member Author

FrauBoes commented Feb 3, 2021

/integrate

@openjdk openjdk bot closed this Feb 3, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 3, 2021
@openjdk
Copy link

openjdk bot commented Feb 3, 2021

@FrauBoes Since your change was applied there have been 21 commits pushed to the master branch:

  • 0ef93fe: 8259265: Refactor UncaughtExceptions shell test as java test.
  • 5324b5c: 8260998: Shenandoah: Restore reference processing statistics reporting
  • c8de943: 8260617: Merge ZipFile encoding check with the initial hash calculation
  • ae2c5f0: 8260581: IGV: enhance node search
  • 9037615: 8222850: jshell tool: Misleading cascade compiler error in switch expression with undefined vars
  • 91e6c75: 8260928: InitArrayShortSize constraint func should print a helpful error message
  • cb127a4: 8198343: Test java/awt/print/PrinterJob/TestPgfmtSetMPA.java may fail w/o printer
  • c008410: 8197825: [Test] Intermittent timeout with javax/swing JColorChooser Test
  • b9d4211: 8260193: Remove JVM_GetInterfaceVersion() and JVM_DTraceXXX
  • 98a7692: 8076313: GraphicsEnvironment does not detect changes in count of monitors on Linux OS
  • ... and 11 more: https://git.openjdk.java.net/jdk/compare/defcb042707b344ff892b78c7360f1c8478e408f...master

Your commit was automatically rebased without conflicts.

Pushed as commit b0ee7a8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated net net-dev@openjdk.org
5 participants