Skip to content

8349860: Make Class.isArray(), Class.isInterface() and Class.isPrimitive() non-native #23572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

8349860: Make Class.isArray(), Class.isInterface() and Class.isPrimitive() non-native #23572

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f0133fc
Make isArray non-native
coleenp Feb 10, 2025
072f332
Make isInterface non-native.
coleenp Feb 10, 2025
c0e9919
Remove isPrimitive intrinsic in favor of a boolean.
coleenp Feb 11, 2025
e8119a2
Shrink modifiers flag so isPrimitive can share word.
coleenp Feb 11, 2025
2d9b9ff
Add ')' removed from jvmci test.
coleenp Feb 18, 2025
3e731b9
Code review comments.
coleenp Feb 19, 2025
d08091a
Rename isPrimitiveType field to primitive.
coleenp Feb 19, 2025
7a4c595
Update src/java.base/share/classes/java/lang/Class.java
coleenp Feb 20, 2025
0234743
Fix whitespace
coleenp Feb 20, 2025
c23718b
Remove JVM_GetClassModifiers from jvm.h too.
coleenp Feb 21, 2025
db7c978
Use modifiers field directly in isInterface.
coleenp Feb 22, 2025
591abdd
Add a comment about Class constructor.
coleenp Feb 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/java.base/share/classes/java/lang/Class.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1292,8 +1292,8 @@
return componentType;
}

// The componentType field's null value is the sole indication that the class is an array,
// see isArray().
// The componentType field's null value is the sole indication that the class

Check failure on line 1295 in src/java.base/share/classes/java/lang/Class.java

View check run for this annotation

openjdk / jcheck-openjdk/jdk-23572

Whitespace error 

Column 81: trailing whitespace
// is an array - see isArray().
private transient final Class<?> componentType;

/*
Expand Down